529490 - "themes is not defined" when I try to set the theme via the settings

Status: RESOLVED INVALID

(Skywriter Graveyard :: Editor, defect)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091109 Ubuntu/9.10 (karmic) Firefox/3.5.5
Build Identifier: BespinEmbedded-0.5

I've started using version 0.5 of bespin-embedded in my despin firefox
extension (http://github.com/past/despin/) and when I try to set the coffee theme via the settings I get the following error:


themes is not defined
chrome://despin/content/BespinEmbedded.js
Line 3481

stack:
anonymous() BespinEmbedded.js (line 3481)
anonymous(Object value=coffee) BespinEmbedded.js (line 3483)
anonymous() BespinEmbedded.js (line 60)
anonymous() BespinEmbedded.js (line 3880)
anonymous("bespin:settings:set:theme", [Object value=coffee 0=Object
isArray=true isObservable=true]) BespinEmbedded.js (line 3877)
anonymous("theme", "coffee") BespinEmbedded.js (line 3717)
anonymous("theme", "coffee") BespinEmbedded.js (line 3161)
anonymous() BespinEmbedded.js (line 3591)
anonymous(function(), Object name=i) BespinEmbedded.js (line 936)
anonymous(div#editor, Object stealFocus=true) BespinEmbedded.js (line 3588)
anonymous("editor", Window editor.html, Object saveOnClose=true
autoindent=on codecomplete=on) editor.js (line 45)
anonymous("/Users/panagiotisastithas/Library/Application
Support/Firefox/Profiles/6zks4crn.development/despin-scratchpad")
commands.js (line 189)
anonymous() commands.js (line 172)
anonymous() commands.js (line 71)
anonymous() editor.html (line 14)
anonymous() jquery-1.3.2.js (line 3032)
anonymous([function(), function() isArray=true isObservable=true
propertyRevision=1], function(), Object name=args) jquery-1.3.2.js
(line 692)
anonymous() jquery-1.3.2.js (line 3031)
anonymous() jquery-1.3.2.js (line 3056)


I had to comment-out the theme setting as a workaround for this one:

http://github.com/past/despin/blob/master/src/content/editor.js#L44


Reproducible: Always

Steps to Reproduce:
1. Download the despin source code.
2. Build the extension running the build.sh script.
3. Install the despin.xpi in Firefox.
4. Click on the despin icon in the status bar or the Tools menu.

Actual Results:  
The described error appeared in the Firebug console. The embedded editor was unusable afterwards.

Expected Results:  
The default coffee theme should have been set and the editor should be functional as usual.

Commenting out the theme setting from the rest, avoids the issue above.

Comment 1

[Gordon P. Hemsley [:GPHemsley]]

Does this still occur in the latest version of Bespin (currently 0.6.2)?

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

I've been experiencing different issues with later versions of Bespin, so I'm not sure. I'll try to fix those and get back to you on this one.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

I can't get this far with bespin 0.6.2. Now I get an error when I upgrade the div to bespin with the manual method, right before I modify the settings. This is the stack trace from Firebug:

responder is undefined
paneDidAttach() BespinEmbedded.js (line 27956)
appendTo(Object { name="elem"}) BespinEmbedded.js (line 27866)
_attachPane() BespinEmbedded.js (line 67838)
init() BespinEmbedded.js (line 67998)
_object_init(Object { name="extensions"}) BespinEmbedded.js (line 11663)
ret(Object { name="props"}) BespinEmbedded.js (line 11510)
create(Object { name="props"}) BespinEmbedded.js (line 11558)
useBespin(Object { name="element"}, Object { name="options"}) BespinEmbedded.js (line 68054)
initUI(Object { name="divId"}, Object { name="window"}, Object { name="prefs"}) editor.js (line 31)
load(Object { name="path"}) commands.js (line 189)
openScratchpad() commands.js (line 172)
onLoad() commands.js (line 71)
(?)() editor.html (line 14)
ready() jquery-1.4.2.js (line 392)
DOMContentLoaded() jquery-1.4.2.js (line 745)

responder.panes.add(this); 


The error is apparently caused by this line in my code:

http://github.com/past/despin/blob/master/src/content/editor.js#L31

Although I can't say what could be wrong with this. I'm using jquery, but I thought it was safe to do so.

Comment 4

[Kevin Dangoor]

I'm marking this bug as invalid, because theme support has not landed in any 
release of Bespin Embedded yet.