529535 - JS Shell line input buffer overflow bug "fix" breaks interactive interpreter

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Wesley W. Garland]

Attachment: mrbkap's patch with the missing assignment

This is a regression caused by bug 413735.

To reproduce, build the JS shell from CVS, run it, and type in two JS statements. The second one will be a syntax error.

[10:43]	<mrbkap>	Wes--: I have the fix.
[10:43]	<mrbkap>	Wes--: My bad -- I lost an assignment when backporting to 1.9.0 :-/
10:45]	<mrbkap>	http://pastebin.mozilla.org/684582
[10:45]	<mrbkap>	But I'm still reading
[10:45]	<mrbkap>	Wes--: File a new bug?

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

Sorry for having to resurrect this, Igor. I don't know how I managed to mangle this quite so badly. Clearly, I didn't test enough.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 413077 [details] [diff] [review]
Fix

This is NPOTB and fixes a pretty severe regression in the JS shell.

Comment 3

[Samuel Sidler (old account; do not CC)]

Comment on attachment 413077 [details] [diff] [review]
Fix

Approved for 1.9.0.16. a=ss

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Thanks, Sam.

Checking in js/src/js.c;
/cvsroot/mozilla/js/src/js.c,v  <--  js.c
new revision: 3.217; previous revision: 3.216
done

Comment 5

[Samuel Sidler (old account; do not CC)]

You're welcome, but next time use the keyword for 1.9.0. ;) (Welcome back from vacation!)