Closed Bug 529573 Opened 15 years ago Closed 14 years ago

Tabular reports do not show empty resolution

Categories

(Bugzilla :: Reporting/Charting, defect)

Product:
Bugzilla
Component:
Reporting/Charting
Version:
3.5.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 3.6

People

(Reporter: gregaryh, Assigned: gregaryh)

References

Details

(Keywords: regression)

Attachments

(1 file)

Tip
627 bytes, patch
mkanat
: review+
Details | Diff | Splinter Review
Attached patch Tip — — Splinter Review 
Report with resolution as an axis leaves out the '---' or empty resolution.
This is a regression from bug 528262.
Attachment #413110 - Flags: review?(mkanat)
Assignee: charting → ghendricks
Status: NEW → ASSIGNED
Depends on: 528262
Keywords: regression
OS: Linux → All
Hardware: x86 → All
Target Milestone: --- → Bugzilla 3.6
Version: 3.4 → 3.5.1
Comment on attachment 413110 [details] [diff] [review]
Tip

The value is an empty string, not a string with a single space.
Attachment #413110 - Flags: review?(mkanat) → review-
Then why does it not show up with an empty string but does with a space? The old code added a space too.
Flags: blocking3.6+
Comment on attachment 413110 [details] [diff] [review]
Tip

Okay, yeah, I suppose that does work. Ideally at some point we should be able to pass the empty string, though, so that it shows up as "---".
Attachment #413110 - Flags: review- → review+
Flags: approval3.6+
Flags: approval+
Max, can you go ahead and check this in? I still don't have bzr set up in my environment.
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified report.cgi
Committed revision 7007.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified report.cgi
Committed revision 6985.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: