52966 - Blank first item in urlbar history popup

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P2)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

The first item in the URLBar history dropdown is blank. This is because there is
a dummy default item in the popup to display when there is nothing selected.
This bug proposes two fixes:

1) Make the dummy item read: "<nothing available>" or similar (a simple entity
hookup)
2) Remove this dummy item when elements are inserted into this menu. (a small
amount of JS).

Will attach a patch.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: changes to navigator.xul

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: changes to navigator.dtd

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: changes to sessionHistoryUI.js

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

patches attached. will await review. nominate for nsbeta3 as fix is in hand. 

Comment 5

[Radha on family leave (not reading bugmail)]

Ben, I'm yet to try your changes.  Will the menu item, "nothing available" show 
up if there are entries in urlbar history and they are going to be listed?

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

the (nothing available) will only show up in the urlbar history dropdown if
there are not yet any entries, e.g. a fresh profile or after the user has
cleared the URLBar history dropdown list through preferences. After entries have
been added to the URLBar history, (nothing available) is never displayed.

Comment 7

[Phil Peterson]

don sez nsbeta3+ pending review from radha

Comment 8

[Radha on family leave (not reading bugmail)]

Ben, changes look good r=radha

Comment 9

[Phil Peterson]

PDT agrees P2, but we'll cut this in a second on Friday

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

fixed. 

Comment 11

[Claudius Gayle]

This is VERIFIED Fixed on all platforms with the 2000092213 builds.

However I believe this fixed introduced a regression:
Bug 53855 'Clear Location(url) Bar History' does not work for current window