529706 - [Prod] tiki-browse_freetags.php contains broken links

Status: VERIFIED FIXED

(support.mozilla.org :: Search, defect, P4)

Description

[Vishal Kamdar [:vish_moz]]

STR:
1. Searching for a free tag like youtube gives some results
(https://support.mozilla.com/tiki-browse_freetags.php?sort_mode=name_asc&tag=youtube)
2. click on the fourth link (Japnese chars) -> gives 404
 
Happening on Prod/Stag/Branch

Comment 1

[Paul Craciunoiu [:paulc]]

Attachment: v1

So, I could repro this locally. It seems the broken URLs are already stored broken in the database. I tried digging for where they are set, but I'm not sure. At any rate, the urls are grabbed from tiki_objects table, column href. For that particular Japanese article, the db value is exactly:
tiki-index.php?page=Flash+%E5%8B%95%E7%94%BB%E3%82%92%E3%83%95%E3%83%AB%E3%82%B9%E3%82%AF%E3%83%AA%E3%83%BC%E3%83%B3%E3%83%A2%E3%83%BC%E3%83%89%E3%81%A7%E5%86%8D%E7%94%9F%E3%81%A7%E3%81%8D%E3%81%AA%E3

This doesn't work: http://support.mozilla.com/tiki-index.php?page=Flash+%E5%8B%95%E7%94%BB%E3%82%92%E3%83%95%E3%83%AB%E3%82%B9%E3%82%AF%E3%83%AA%E3%83%BC%E3%83%B3%E3%83%A2%E3%83%BC%E3%83%89%E3%81%A7%E5%86%8D%E7%94%9F%E3%81%A7%E3%81%8D%E3%81%AA%E3

However, simply using the article title for wiki pages works, and I hope this is acceptable until we find the cause.

Comment 2

[James Socol [:jsocol, :james]]

Comment on attachment 413889 [details] [diff] [review]
v1

This patch WFM in the articles I tested (including Japanese).

Ultimately, though, tiki-browse_freetags is clunky, difficult to navigate and use, and doesn't offer much value from my perspective. Even with this patch fixing the errors, I'd still like to take the "more" link off the start page or point it somewhere else.

Comment 3

[Paul Craciunoiu [:paulc]]

(In reply to comment #2)
> I'd still like to take the "more" link off the start page or point it somewhere else.
I agree.

Comment 4

[Paul Craciunoiu [:paulc]]

r56671

Comment 5

[Vishal Kamdar [:vish_moz]]

Verified, FIXED.