###!!! ABORT: Decoded but frame not available?: '!mDecoded', file /builds/moz2_slave/mozilla-central-linux-debug/build/modules/libpr0n/src/imgContainer.cpp, line 2362

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Core
ImageLib
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: roc, Assigned: Joe Drew (not getting mail))

Tracking

Trunk
mozilla1.9.3a1
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.63 KB, patch
jrmuizel
: review+
Bobby Holley (parental leave - send mail for anything urgent)
: review+
Details | Diff | Splinter Review
http://tinderbox.mozilla.org/showlog.cgi?tree=Firefox-Unittest&errorparser=unittest&logfile=1258592998.1258598758.8585.gz&buildtime=1258592998&buildname=Linux%20mozilla-central%20debug%20test%20everythingelse&fulltext=1#err0
(Assignee)

Comment 1

8 years ago
Disabled the tests temporarily:

http://hg.mozilla.org/mozilla-central/rev/72e61f2a524f
(Assignee)

Comment 2

8 years ago
Created attachment 413272 [details] [diff] [review]
remove bogus NS_ABORT_IF_FALSE, re-enable tests

Asserting that Get(Current)DrawableImgFrame() must always return non-null is bogus, and we shouldn't do that.
Assignee: nobody → joe
Attachment #413272 - Flags: review?(jmuizelaar)
Attachment #413272 - Flags: review?(bobbyholley)
Comment on attachment 413272 [details] [diff] [review]
remove bogus NS_ABORT_IF_FALSE, re-enable tests

I don't really have any idea what the implications of this are, but it seems like this is better to have in the tree than not. Still, it would be nice to hear what went wrong here.
Attachment #413272 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 4

8 years ago
I answered this in real life, but for posterity:

The whole point of GetDrawableImgFrame and friends is that it can return null in the case that we failed to create a drawable image frame from a paletted frame. Before bug 523528, we would just try to draw a paletted image frame and crash. 

Now, we notice when we fail to create an imgFrame because new returned null or imgFrame::Init() returned an error. (Init returns an error when we're low on virtual memory - see nsIMemory - or when the image's size is too large.) In those cases, GetDrawableImgFrame returns null, instead of returning a paletted image frame that crashes when we call Draw() on it.
(Assignee)

Comment 5

8 years ago
http://hg.mozilla.org/mozilla-central/rev/059f82786fc8
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Comment on attachment 413272 [details] [diff] [review]
remove bogus NS_ABORT_IF_FALSE, re-enable tests

Comment below the removed line is now slightly inaccurate, but w/e. r+
Attachment #413272 - Flags: review?(bobbyholley) → review+
You need to log in before you can comment on or make changes to this bug.