Closed Bug 529773 Opened 13 years ago Closed 13 years ago

nsProtocolProxyService::PrefsChanged / nsProtocolProxyService::Resolve_Internal don't behave cleanly when do_GetService(NS_SYSTEMPROXYSETTINGS_CONTRACTID) fails

Categories

(Core :: Networking, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1
Tracking Status
status1.9.2 --- final-fixed

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(1 file)

split off from bug 500983 comment 16
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #413295 - Flags: review?(cbiesinger)
Attachment #413295 - Flags: review?(cbiesinger) → review+
http://hg.mozilla.org/mozilla-central/rev/5a38aad4bde8
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Comment on attachment 413295 [details] [diff] [review]
act like preference is Direct when SystemProxy isn't available

Requesting approval1.9.2 for this fix to ensure our code uses the direct preference when there is not a SystemProxy.
Attachment #413295 - Flags: approval1.9.2?
Comment on attachment 413295 [details] [diff] [review]
act like preference is Direct when SystemProxy isn't available

a192=beltzner, post-hoc, reed has been scolded appropriately for landing without approval
Attachment #413295 - Flags: approval1.9.2? → approval1.9.2+
Depends on: 586908
You need to log in before you can comment on or make changes to this bug.