Closed
Bug 529773
Opened 15 years ago
Closed 15 years ago
nsProtocolProxyService::PrefsChanged / nsProtocolProxyService::Resolve_Internal don't behave cleanly when do_GetService(NS_SYSTEMPROXYSETTINGS_CONTRACTID) fails
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | final-fixed |
People
(Reporter: timeless, Assigned: timeless)
References
Details
Attachments
(1 file)
|
2.32 KB,
patch
|
Biesinger
:
review+
beltzner
:
approval1.9.2+
|
Details | Diff | Splinter Review |
split off from bug 500983 comment 16
|
||
Updated•15 years ago
|
Attachment #413295 -
Flags: review?(cbiesinger) → review+
|
||
Updated•15 years ago
|
Keywords: checkin-needed
|
||
Comment 2•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/5a38aad4bde8
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 413295 [details] [diff] [review] act like preference is Direct when SystemProxy isn't available Requesting approval1.9.2 for this fix to ensure our code uses the direct preference when there is not a SystemProxy.
Attachment #413295 -
Flags: approval1.9.2?
|
||
Comment 4•15 years ago
|
||
Comment on attachment 413295 [details] [diff] [review] act like preference is Direct when SystemProxy isn't available a192=beltzner, post-hoc, reed has been scolded appropriately for landing without approval
Attachment #413295 -
Flags: approval1.9.2? → approval1.9.2+
|
|
||
Comment 5•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/03c71e19d0d5
status1.9.2:
--- → final-fixed
|
|
||
Updated•15 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•