Need to force default bookmarks import if mobile bookmarks root doesn't exist

RESOLVED FIXED in fennec1.0

Status

Firefox for Android Graveyard
Bookmarks
RESOLVED FIXED
9 years ago
3 years ago

People

(Reporter: Gavin, Assigned: Gavin)

Tracking

Trunk
fennec1.0

Details

Attachments

(1 attachment)

Our front end code will depend on the existence of a "mobile" bookmarks root once the patch for bug 525184 lands. New profiles have this by default (it's defined in the default bookmarks file), but to support existing profiles we'll need to also check for it and then force non-destructive default bookmarks import. This also has the advantage of adding the default bookmarks for people who don't already have them.

The patch makes two changes - forces import if the mobile root doesn't exist, and changes the "aReplace" argument in our call to restoreBookmarksFromJSONString to avoid overwriting existing bookmarks.
Created attachment 413379 [details] [diff] [review]
patch

I'm worried about the perf impact of starting the annotation service this early on startup, but I don't think there's really any way to avoid that...
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #413379 - Flags: review?(mark.finkle)
Attachment #413379 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mobile-browser/rev/f305d4de5ece
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Post-B5
Flags: in-litmus?
Component: General → Bookmarks
I'm reassigning this to myself for adding litmus testcases for this (aakashd discussed this on irc with blassey and ted on #mobile).

Tchung mentioned this should be a FFT test.
Assignee: gavin.sharp → martijn.martijn
Assignee: martijn.martijn → gavin.sharp
Flags: in-litmus? → in-litmus?(martijn.martijn)
Flags: in-litmus?(martijn.martijn)
You need to log in before you can comment on or make changes to this bug.