Closed Bug 529860 Opened 12 years ago Closed 11 years ago

Provide a method to enlarge timeout for some browser chrome tests

Categories

(Testing :: Mochitest, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: mak, Assigned: mak)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [automatic test commented out since would take too much time on tinderboxes])

Attachments

(1 file, 2 obsolete files)

bug 527614 brought this to SimpleTest, we have some b-c test that takes longer times (for example the tests in bug 507172 or in bug 525610) than others, and those tests are timing our randomly.

The timeout should be large enough for any test, but looks like on VMs it has some strange behavior (like timing out in seconds rather than minutes)
Blocks: 507172, 525610
Summary: evaluate if we want enlarged timeouts on b-c tests → Provide a method to enlarge timeout for some b-c tests
Attached patch patch v1.0 (obsolete) — Splinter Review
builds on top of patches in bug 528469 and bug 485269
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attachment #416078 - Flags: review?(gavin.sharp)
(In reply to comment #0)
> The timeout should be large enough for any test, but looks like on VMs it has
> some strange behavior (like timing out in seconds rather than minutes)

this is actually incorrect, the timeout in b-c is 30 seconds, while looks like mochitests have larger timeouts. the patch allows to extend the 30 seconds base value by an integer factor.
Summary: Provide a method to enlarge timeout for some b-c tests → Provide a method to enlarge timeout for some browser chrome tests
Attached patch patch v1.1 (obsolete) — Splinter Review
Attachment #416078 - Attachment is obsolete: true
Attachment #416078 - Flags: review?(gavin.sharp)
Flags: in-testsuite?
Comment on attachment 421860 [details] [diff] [review]
patch v1.1

i'll push all three patches to tryserver
Attachment #421860 - Flags: review?(gavin.sharp)
Whiteboard: to be applied on top of patch in bug 528469 and bug 485269
Depends on: 528469
Comment on attachment 421860 [details] [diff] [review]
patch v1.1

>diff --git a/testing/mochitest/browser-test.js b/testing/mochitest/browser-test.js

>       this.currentTest.scope.__waitTimer = setTimeout(function() {
>+        if (--self.currentTest.scope.__timeoutFactor > 0) {
>+          // Wait a bit longer.

Maybe add a self.currentTest.scope.info("Waiting longer; __timeoutFactor: " + self.currentTest.scope.__timeoutFactor); ?
Attachment #421860 - Flags: review?(gavin.sharp) → review+
Keywords: dev-doc-needed
Attached patch patch v1.2Splinter Review
addressed comment
Attachment #421860 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/baaa8aea09ab
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
Whiteboard: to be applied on top of patch in bug 528469 and bug 485269 → [automatic test commented out since would take too much time on tinderboxes]
Target Milestone: --- → mozilla1.9.3a1
Blocks: 550354
Component: BrowserTest → Mochitest
You need to log in before you can comment on or make changes to this bug.