529860 - Provide a method to enlarge timeout for some browser chrome tests

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

bug 527614 brought this to SimpleTest, we have some b-c test that takes longer times (for example the tests in bug 507172 or in bug 525610) than others, and those tests are timing our randomly.

The timeout should be large enough for any test, but looks like on VMs it has some strange behavior (like timing out in seconds rather than minutes)

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.0

builds on top of patches in bug 528469 and bug 485269

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to comment #0)
> The timeout should be large enough for any test, but looks like on VMs it has
> some strange behavior (like timing out in seconds rather than minutes)

this is actually incorrect, the timeout in b-c is 30 seconds, while looks like mochitests have larger timeouts. the patch allows to extend the 30 seconds base value by an integer factor.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.1

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 421860 [details] [diff] [review]
patch v1.1

i'll push all three patches to tryserver

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 421860 [details] [diff] [review]
patch v1.1

>diff --git a/testing/mochitest/browser-test.js b/testing/mochitest/browser-test.js

>       this.currentTest.scope.__waitTimer = setTimeout(function() {
>+        if (--self.currentTest.scope.__timeoutFactor > 0) {
>+          // Wait a bit longer.

Maybe add a self.currentTest.scope.info("Waiting longer; __timeoutFactor: " + self.currentTest.scope.__timeoutFactor); ?

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.2

addressed comment

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/baaa8aea09ab

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

updated docs in https://developer.mozilla.org/en/Browser_chrome_tests