Use a specific or a generic string for descriptions of search instead of <description>

VERIFIED FIXED in fennec1.0

Status

Fennec Graveyard
General
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Pike, Assigned: Gavin)

Tracking

({productization})

Trunk
fennec1.0
productization

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Using the <description> tag inside our search plugin for the details in the add-ons manager would cause us to fork our search plugins, in particular, the google one, which conflicts with bug 511017, where google requests to be able to offer dynamic updates on their own behalf.

Let's take an alternative route:

Add a generic string with a rich localization note that, in en-US, says something like
"Integrated %S Search"

That string should be fallback to a specific localizable entry per engine, that'd be keyed off the name of the plugin, and would live in region.properties. So a localizer could do a generic string like:
"Intergrated search on %S"
and overload that in region.properties with something like
"Integrated search with Google"
for Google.

The entries in region.properties should have a pattern added to filter.py so that they're ignored, similar to what we do with the order entries.
mfinkle points out that we could also just use a single generic "Integrated search engine" string, since the name is displayed right above it anyways. Would be a lot simpler...
(Reporter)

Comment 2

8 years ago
fine with me either way.
Created attachment 413462 [details] [diff] [review]
patch

This adds a generic fallback, and removes the description from the en-US plugins (which are the only ones that will potentially be shared across-locales). This means that localized engines or engines installed from the web can still specify custom descriptions.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #413462 - Flags: review?(mark.finkle)
Attachment #413462 - Flags: review?(l10n)

Updated

8 years ago
Attachment #413462 - Flags: review?(mark.finkle) → review+
(Reporter)

Updated

8 years ago
Attachment #413462 - Flags: review?(l10n) → review+
https://hg.mozilla.org/mobile-browser/rev/fe85e40ae731
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Post-B5
verified FIXED on builds:


Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b4pre) Gecko/20091120 Firefox/3.6b4pre Fennec/1.0b6pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091120 Firefox/3.7a1pre Fennec/1.0b5
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.