529892 - Add enigmail to the block list for rc1

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Ludovic Hirlimann [:Usul]]

To make sure our users won't crash because of those application :

from dmose's email
I would suggest filing a bug to investigate adding those two extensions to the blocklist, because having an automated way to guarantee that such users won't crash would be the ideal.  If it turns out to be impractical or there's no time, then it can be tagged with relnote as well.

Comment 1

[Mark Banner (:standard8)]

So enigmail less than the updated version (1.0pre?) I can understand adding to the blocklist.

I can't understand about Lightning - unless someone turns of compatibility checking (which if they do that's their own issue IMHO), then we didn't publish any nightly versions that are incompatible with TB 3.0 until we did the first release candidate, so I don't see a super-bad user experience there.

Comment 2

[David Ascher (:davida)]

Why does the logic for Lightning not apply to Enigmail?

(for 3.1, I assume we'll get for free the per-version compatibility checking behavior?)

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #2)
> Why does the logic for Lightning not apply to Enigmail?

Lightning nightly builds have a max version equivalent to the nightly version of Thunderbird that is being built.

So before we produced RC1 build 1, the Lightning nightly builds had a max version of 3.0pre after RC1 build 1 they had 3.0.1pre.

(Note that we could probably actually switch that to 3.0.* now, but that's a different bug).

AFAIK those builds will be compatible with 3.0 final.

To the contrary, for enigmail (and all non-tree extensions) it is up to the author to set the max version.

So we only need to add a broken enigmail version to the blocklist if it was advertised as being compatible with 3.0 or 3.0.* whilst we were still in the 3.0pre stage and then changed some APIs.

(Note that FF has an API freeze between last beta and RC which is why Patrick may have upped the version here assuming we were doing the same).

> (for 3.1, I assume we'll get for free the per-version compatibility checking
> behavior?)

We've always got the compatibility checking (even in 2.0), but it is up to the author to ensure it is set right.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

When I made that suggestion, my assumption was that Ludo knew of a similar crash problem with Lightning as described with enigmail.  If that's not the case, then just adding Enigmail sounds like the way to go.

Comment 5

[Ludovic Hirlimann [:Usul]]

Right and I was not clear , issue I wanted to avoid with lighting was dataloss - but standard8 said it got fixed november 15th (max min versions are now correct).

Comment 6

[Patrick Brunschwig]

(In reply to comment #1)
> So enigmail less than the updated version (1.0pre?) I can understand adding to
> the blocklist.

Right, Enigmail < 1.0pre is incompatible with RC1.

Comment 7

[Mark Banner (:standard8)]

(In reply to comment #6)
> (In reply to comment #1)
> > So enigmail less than the updated version (1.0pre?) I can understand adding to
> > the blocklist.
> 
> Right, Enigmail < 1.0pre is incompatible with RC1.

If:

- enigmail < 1.0pre is incompatible with RC1 (or 3.0.*) and
- 1.0pre (any version) is compatible with RC1 and doesn't suffer any crashes

Therefore the only issue we have here are users still on 3.0pre that are using enigmail < 1.0pre.

So my understanding is that we don't have issues with enigmail being advertised as compatible with 3.0 (or 3.0.*) but not actually being compatible.

All of which makes me think whilst 3.0pre and enigmail < 1.0pre is an issue, I'm not actually sure it is worth getting it added to the block list.

Comment 8

[Mark Banner (:standard8)]

From the reports we're getting with 3.0RC1 pre there is at least one version of enigmail out there that reports as version 0.96a and shows compatible with Thunderbird 3.0. From the reports we're pretty sure that this is some 64 bit builds on Linux, but there may be others as well.

As we seem to be hitting this a lot, we've decided we will add enigmail to the add-on blocklist and I think the best restriction will be as follows:

In Thunderbird 3.0pre and Thunderbird 3.0*, block enigmail 0.97 and less.

Reopening for tracking purposes - the actual blocklist update will be performed in another bug that will block this one.

Comment 9

[Mark Banner (:standard8)]

(In reply to comment #8)
> In Thunderbird 3.0pre and Thunderbird 3.0*, block enigmail 0.97 and less.

Just to clarify I made the max version 0.97a as that was the last nightly version before the issue was fixed.

Comment 10

[Patrick Brunschwig]

That's perfectly right.

PS. For future versions I'll change my nightly builds to not be compatible with release versions (*.0.0) anymore.

Comment 11

[Mark Banner (:standard8)]

Bug 531047 is now fixed and this should be as well. Blocklist updates should filter through to users over the next few days.