Closed Bug 530056 Opened 15 years ago Closed 14 years ago

Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsICrashReporter.annotateCrashReport] in browser.js

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3.7a1
Tracking Status
status1.9.2 --- .4-fixed

People

(Reporter: dao, Assigned: Natch)

References

Details

(Keywords: regression, Whiteboard: [notacrash])

Attachments

(1 file)

I'm getting this every time a page loads:

Error: [Exception... "Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsICrashReporter.annotateCrashReport]"  nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)"  location: "JS frame :: chrome://browser/content/browser.js :: anonymous :: line 6463"  data: no]
Source File: chrome://browser/content/tabbrowser.xml
Line: 502

Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.9.3a1pre) Gecko/20091120 Minefield/3.7a1pre
Keywords: regression
Should probably be checking nsICrashReporter.enabled before calling annotate. The sessionstore code had a bunch of checks for this (crashreporter not compiled in/not enabled), I guess they didn't make it to the new code.
Whiteboard: [notacrash]
So this is why I keep getting this in home-made builds....

->me
Assignee: nobody → highmind63
Umm, actually the only place that calls this in browser.js is #ifdef'd MOZ_CRASHREPORTER... something's wrong...
Attached patch patchSplinter Review
Ok, so while the crash reporter may be built-in to the app (it is by default) it may be disabled, so I've added the check ted mentioned...
Attachment #420171 - Flags: review?(ted.mielczarek)
Attachment #420171 - Flags: review?(ted.mielczarek) → review+
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 3.7a1
Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/46a21376e0a7
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Attachment #420171 - Flags: approval1.9.2.1?
Comment on attachment 420171 [details] [diff] [review]
patch

Safe fix to prevent error console spam. Should take next time.
Attachment #420171 - Flags: approval1.9.2.3?
Attachment #420171 - Flags: approval1.9.2.2?
Attachment #420171 - Flags: approval1.9.2.2-
Comment on attachment 420171 [details] [diff] [review]
patch

Approved for 1.9.2.4, a=dveditz for release-drivers
Attachment #420171 - Flags: approval1.9.2.4? → approval1.9.2.4+
Thanks reed! I'm sorry I couldn't get to it, I was trying but could not get an ample enough source of internet :)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: