530090 - [HTML5] Memory leaks using jArray in HTML5 parser

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[zbychs]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 (.NET CLR 4.0.20506) FBSMTWB
Build Identifier: 

There are some minor memory leaks here: http://mxr.mozilla.org/mozilla-central/source/parser/html/nsHtml5Tokenizer.h#284 as well as in several simillar places.
The reason for those leaks is that constructor that initializes the 0-length jArray  allocates 0-length buffer, which is never deleted.
Fixing bug 502176 would make this one obsolete.

Note from Henri Sivonen:
"The definitions are in generated code that shouldn't be patched directly. A patch for the generator or to jArray.h would be awesome, though. Since jArray.h needs to be able to represent null, I think probably the right fix is to make jArray.h behave differently when 0 is assigned to it."

Reproducible: Always

Comment 1

[zbychs]

Attachment: Quick and dirty fix of memory leaks.

Comment 2

[Henri Sivonen (:hsivonen)]

Editing summary to put this on the radar. Thanks for finding this and providing a patch.

Comment 3

[Henri Sivonen (:hsivonen)]

Comment on attachment 413623 [details] [diff] [review]
Quick and dirty fix of memory leaks.

r=hsivonen. I'll land this.

Comment 4

[Henri Sivonen (:hsivonen)]

Thank you for the patch. Pushed:
http://hg.mozilla.org/mozilla-central/rev/8cdb992f92f7