When you move to the 1.9.2 branch you should look at removing some/all of the extensions.getMore* preferences as these will once again make links appear in the add-ons manager. For Firefox we have removed all but the getMoreThemes link as we want a link to download themes in addition to the Get Add-ons panel in the manager.
SeaMonkey uses this pref elsewhere (View > Apply Theme > Get New Themes), we can't just remove this.
The only pref kept on last Daily (18) is extensions.getMoreThemesURL.
(In reply to Javi Rueda from comment #2)
> The only pref kept on last Daily (18) is extensions.getMoreThemesURL.
Actually, afaict this isn't used now, and doesn't need to be in FF any more neither.
It seems ok to remove it from the comm-central repository (/calendar and /mail only) and from the mozilla-central.
Created attachment 658861 [details] [diff] [review]
patch for m-c
Removes references for getMore* preference on the mozilla-central repository.
This patch also modifies a JS-Shell regression test for bug 308111. I tried to run an automated testing and it didn't show any message about failing on this specific test.
Those preferences will be removed also on the comm-central repository (sunbird and thunderbird).
Changes for seamonkey are under research. Opinions on this?
Thank you, Ehsan.
Comment on attachment 658861 [details] [diff] [review]
patch for m-c
I know absolutely nothing about what this pref does!
My computer is down -probably power supply broken- so, to I am requesting for check-in the patch in order to avoid problems in case the code changes and could not be applied.
It is still needed to make the change in comm-central. i am unsure if a patch could also be created for suite as the string seems to be used on code.
If anybody wants to work on this, feel free to take it -without asking- if there were no news from me :-)
The string also appears in the IM directory in http://mxr.mozilla.org/comm-central/source/mail/components/im/content/imAccountWizard.js#8
I thought it could be a placeholder, but, as I was unsure, I asked on the IRC. This was what clokep answered me.
21:15:40 - clokep: kekkyojin: I'm pretty sure that that preference is supposed to point to https://addons.mozilla.org/en-US/thunderbird/addon/additional-chat-protocols/, can you CC :clokep and :florian to that bug and ask in the bug? (florian should know)
Then, :florian and :clokep, what do you think about that? Should it be removed or be kept?
Created attachment 687846 [details] [diff] [review]
Patch for c-c
Hi, Blake. It seems all patches I submit could be reviewed by you :-\ :-/
Could you look at this one?
I tested it by opening the Add-ons Manager from the main menu and all seems to be working right and there were no eror messages at the Error Console.
(In reply to Javi Rueda from comment #10)
> Then, :florian and :clokep, what do you think about that? Should it be
> removed or be kept?
It's mostly a UX decision, so Blake can decide. Either we need to add the pref to make the "Show more protocols" link appear in the account wizard, or we can remove the dead code if we don't want to have that link in the UI. You can also just not change anything.
If you are going to remove this code, or are adding a value to the pref, please request review from me on the patch doing that.
Patch in attachment 687846 [details] [diff] [review] doesn't include any code for the Chat component in Thunderbird. That part will be seen later.
Comment on attachment 687846 [details] [diff] [review]
Patch for c-c
(In reply to Florian Quèze [:florian] [:flo] from comment #12)
> (In reply to Javi Rueda from comment #10)
> It's mostly a UX decision, so Blake can decide. Either we need to add the
> pref to make the "Show more protocols" link appear in the account wizard, or
> we can remove the dead code if we don't want to have that link in the UI.
> You can also just not change anything.
I would be happy to see a "Show more protocols" link in the chat acount wizard, but I think that we should leave this change for a future patch.
I'm happy with the patch itself, but it would be nice to wait for a clean try-server run before we check it in.
(I've kicked one off at https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=a1cc305a2675 for you.)
Thanks, and I apologize for the delay in reviewing this patch.
There were some orange statuses on the try-server. Looking at the reports with such a colour, there were many "intermitent oranges". As I am unsure if that is the way it should be, I prefer to wait before asking for a check-in.
A new try-server run would be needed, Blake?
On the other hand, no problem about the delay. These days are always very busy ones :-)
I think we're probably safe, since they are intermittent, and since they seem unrelated to the change, but let's double-check with Standard8 before landing…
Yeah, just intermittent, we're good to go here. Sorry for the delay in looking at this.