53011 - United Nations homepage messed up

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P1)

Description

[R.K.Aa.]

2000091606 M18 Linux

http://www.un.org/english/ lays out wrong, images missing, comments showing,
columns wrong. The js mouseover menus appear in one long column instead of on
each side of the logo. Since one now has to scroll far down to see all links,
the explanation for them becomes "invisible", because it displays out of reach,
near top of page (where it should display).

Comment 1

[Doron Rosenberg (IBM)]

--> layout, seeing also on win32.

<!-----------------------------------------------
This is the start of bottom utility Navigation bar
------------------------------------------------->

I assume that is causing the problems, as the text is shown in win32.

Comment 2

[Asa Dotzler [:asa]]

possibly because this page declares a HTML 4 Strict DTD and doens't even come
close to validating?

Comment 3

[Asa Dotzler [:asa]]

over to Parser.

Comment 4

[rickg]

The strictDTD is disabled. I'll take a quick look to see if this has *anything*
to do with the parsing engine.

Comment 5

[rickg]

The problem is that comments are being parsed in "strictmode" on this page with 
a strict Doctype. I neglected to disable this. It's a one line change. 
Requestion RTM++.

Comment 6

[rickg]

This is related to turning off the strictDTD. It's absolutely essential that it 
go in for RTM, or we'll break on lots of badly formed pages.

Comment 7

[rickg]

marking ++ for review.

Comment 8

[Michael La Guardia]

PDT thought strict dtd was already disabled.  What's the issue now?  Cc'ing
Vidur and Harish.  Please get this bug reviewed and super reviewed.

Comment 9

[harishd]

This involves strict comment parsing ( doesn't happen in the DTD ) in 
HTMLTokenizer. Yes, this should be disabled too.

Comment 10

[rickg]

Here's the patch:

Index: nsHTMLTokens.cpp
===================================================================
RCS file: /cvsroot/mozilla/htmlparser/src/nsHTMLTokens.cpp,v
retrieving revision 3.173
diff -r3.173 nsHTMLTokens.cpp
999a1000,1001
>
> #if 0 //set to 1 if you want strict comments...  bug 53011...
1002a1005,1006
> #endif
>

Comment 11

[Phil Peterson]

PDT marking [rtm need info] since it appears that the patch hasn't been
code-reviewed yet.

Comment 12

[rickg]

The code has been reviewed and superreviewed by buster.

Comment 13

[Phil Peterson]

PDT marking back to need info. Reviewer and super reviewer must be distinct.

Comment 14

[rickg]

Ok -- reviewed by Attinasi.

Comment 15

[Phil Peterson]

pdt:  ++.

Comment 16

[rickg]

Fixed by preventing strict comment handling, period.

Comment 17

[R.K.Aa.]

SEA 2000101212 linux
The UN pages now look good again - fix fixed everything reported in this bug :)

Comment 18

[Jan Carpenter]

verified per reporter comments