530121 - Locale detection does not work for fi on mozilla.com

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Jussi Bergström]

Note: I suspect this occurs only in Finland, because if this was global, someone surely would have already reported this...

Steps to reproduce:
1. Live in Finland.
2. Go to any mozilla.com address with a subdirectory without a locale code, e.g. http://www.mozilla.com/firefox/ or http://www.mozilla.com/firefox/security/ (anything will fail except http://www.mozilla.com/).
3. A 404 "Hmmm, we’re having trouble finding that one." is shown.

Expected results:
The user is redirected to the appropriate URL (with the lc in it) either at mozilla.com or mozilla-europe.org.

Tested browsers and environments:
Fx 3.5/Windows/Linux
Fx 3.6b3/Windows
IE 8/Windows
This happens even if I use a different machine in a completely different network.

Comment 1

[Jussi Bergström]

Additional details:
1. Of course even en-US would be acceptable, but the redirect fails altogether.
2. If I type in the lc manually, a page is loaded correctly.

Comment 2

[Alex Buchanan [:abuchanan]]

I set my browser language to German, to confirm locale detection works for other languages, and was redirected correctly.

I hit,
mozilla.com/firefox/security
and was redirected to,
http://www.mozilla-europe.org/de/firefox/security/

I repeated with browser set to Finnish, and confirmed Jussi's report.

It's very odd that only Finnish wouldn't work, possibly there are other broken locales.

Comment 3

[Alex Buchanan [:abuchanan]]

CC'ing Wil, this could this be related to bug 526923

Comment 4

[Alex Buchanan [:abuchanan]]

(In reply to comment #3)
> CC'ing Wil, this could this be related to bug 526923

Er, actually, that bug only affects lang codes that are remapped, and FI is not.  So, I think they are not related.  Sorry.

Comment 5

[Alex Buchanan [:abuchanan]]

Ok, found the problem.

prefetch.php line 176

The firefox2 in-product page code tries to match a lang code to the _SERVER[REDIRECT_URL].  The Finnish lang code, fi, happens to match the first to letters of "firefox" which munges the REDIRECT_URL, and causes the 404

Comment 6

[Alex Buchanan [:abuchanan]]

Attachment: patch v1

Comment 7

[Wil Clouser [:clouserw]]

Comment on attachment 413668 [details] [diff] [review]
patch v1

Should work

Comment 8

[Alex Buchanan [:abuchanan]]

r56601 checks patch v1 into trunk

Comment 9

[Alex Buchanan [:abuchanan]]

To QA you should do something along the lines of,

* Set your browser's locale to Finnish
* Test the root and subpages, e.g. home page and something like /firefox/security
* Test by visiting a URL with the locale already set, e.g. /fi/firefox/security
* Finnish ("fi") is the main one to test, but you could try out a couple other locales too

Hope that helps the QA folks.  

This is possibly affecting a large number of Finnish users right now, so we should get this out the door soon please.

Thanks.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

[1] www-trunk.stage.mozilla.com/firefox redirected me to http://www.mozilla-europe.org/fi/firefox/
[2] http://www-trunk.stage.mozilla.com/fi/firefox/security/ redirects me to http://www.mozilla-europe.org/fi/firefox/security/
[3] http://www-trunk.stage.mozilla.com/firefox/security redirected me to http://www.mozilla-europe.org/fi/firefox/security/
[4] http://fi.www-trunk.stage.mozilla.com/fi/ works
[5] When changing to |de| (in Firefox), www-trunk.stage.mozilla.com/firefox/security redirects to http://www.mozilla-europe.org/de/firefox/security/

I think we're good here, but I'm still a bit nervous (thank goodness Raymond is working on automated tests here!)

Comment 11

[Alex Buchanan [:abuchanan]]

I'd like to push this live today, please.

What's left for QA?

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #11)
> I'd like to push this live today, please.
> 
> What's left for QA?

Nothing -- that was what comment 10 intended to say.

Comment 13

[Alex Buchanan [:abuchanan]]

r56792 tags for production.

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Jussi, can you confirm this is now working for you?  Thanks!

Comment 15

[Jussi Bergström]

Oh, sorry, I meant to confirm much earlier already but forgot... Everything's fine now. Thanks to everyone for fixing this!

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

Looks like this is covered in http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/tests/mozillaRewrites.php?revision=57321&view=markup, so in-testsuite+