<xul:scrollbox> generates infinite onoverflow events

ASSIGNED
Assigned to

Status

()

Core
XUL
P3
normal
ASSIGNED
18 years ago
10 years ago

People

(Reporter: Robert Ginda, Assigned: Eric Vaughan)

Tracking

Trunk
mozilla1.0.1
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

18 years ago
Save the attached files to the same directory
Load onoverflow.xul
Drag the slider so that the images are clipped.  

When I do that, I see the onoverflow handler called repeatedly.  If I remove
every other image, everything works fine; so it seems to me to have something to
do with images of various sizes.
(Reporter)

Comment 1

18 years ago
Created attachment 14898 [details]
onoverflow.xul; the xul testcase
(Reporter)

Comment 2

18 years ago
Created attachment 14899 [details]
EVAL-IN.gif; image used by the testcase
(Reporter)

Comment 3

18 years ago
Created attachment 14900 [details]
EVAL-OUT.gif; another image used by the testcase
(Assignee)

Comment 4

18 years ago
Yep a very simple bug. On line 440 in nsScrollBoxFrame vertChanged is outside 
the {} above. So if the size changed it always fires when it should only fire 
the first time. Should look like this instead:

    if (!mVerticalOverflow) {
       mVerticalOverflow = PR_TRUE;
       vertChanged = PR_TRUE; // inside {}
    }

Is this a performance problem? How often are the extra ones fired. Does it 
happen when just running the browser?
Status: NEW → ASSIGNED
(Reporter)

Comment 5

18 years ago
I came across it while using <scrollbox>s in another xul app, I'm not sure if it
shows up in the browser scrollbox usage or not.
(Assignee)

Comment 6

18 years ago
Actually my first patch won't work. When the size gets bigger it must always 
post a overflow. So never mine. I'll look at the example and see what's 
happening.

Comment 7

18 years ago
->future
Target Milestone: --- → Future
(Assignee)

Updated

18 years ago
Target Milestone: Future → mozilla0.9

Comment 8

18 years ago
->moz1.0
Target Milestone: mozilla0.9 → mozilla1.0

Comment 9

17 years ago
What's the status of this bug?

Comment 10

17 years ago
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)
Target Milestone: mozilla1.0 → mozilla1.0.1

Comment 11

13 years ago
I think that following test case is for this bug.

<?xml version = '1.0' encoding = 'UTF-8'?><!-- -*- nxml -*-
   Time-stamp: "Wed Dec 21 12:01:33 EET 2005"
-->
<window id="nai" title="- Development -"
        xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
	xmlns:xhtml="http://www.w3.org/1999/xhtml">

<!-- Segmentation fault on my, malfunction on winxp: -->
<scrollbox>
<textbox multiline="true"/>
</scrollbox>

<!-- same -->
<scrollbox>
<box style="overflow:scroll"/>
</scrollbox>

<!-- Element doesn't have scrollbars for manual scrolling -->
<scrollbox style="overflow:scroll!important">
<label value="one,two"/>
</scrollbox>

</window>

Comment 12

13 years ago
Yes, btw, my build is:

Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.12) Gecko/20050924
Debian GNU+Linux

Firefox and Mozilla-suite

Updated

10 years ago
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.