Closed Bug 53017 Opened 23 years ago Closed 23 years ago

Editor does not regain focus after dialog is dismissed.(Linux)

Categories

(Core :: XUL, defect, P2)

Product:
Core
Component:
XUL
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
VERIFIED WORKSFORME

People

(Reporter: jrgmorrison, Assigned: blizzard)

References

Details

(Whiteboard: [nsbeta3-][PDTP2][rtm need info]) 

Overview Description: 

This is a follow-on from bug 49975, but specifically for linux. 

If you bring up a dialog (e.g. Table, Link, ...) and dismiss it focus is not 
returned to the document. Without focus in the document, you cannot relaunch 
any of the six right-most dialogs. Workaround is to manually reset focus in 
the document after you dismiss a dialog. 


Steps to Reproduce: 

1) Start Composer.
2) Enter some text.
3) Bring up one of the Dialogs (e.g., Image)
4) Cancel out of that dialog.
5) Try to enter text in the document.
6) Try to bring up the dialog.

Actual Results:   Can't enter text or launch dialog, until you set focus
                  in the document again with the mouse.
Expected Results: Focus automagically returns to the document when the dialog
                  goes away.

Reproducibility: 100% on linux

Build Date & Platform Bug Found: 
   netscape build 2000091721 linux rh6.1

  DOES NOT OCCUR
   mozilla  build 2000091505 win2k
   netscape build 2000091520 mac os9.0

This was a nsbeta3+ bug in it's previous form. Adding in the nomination.
-> nsbeta3 nom.
Keywords: nsbeta3
nsbeta3+, p2 for M18.  Apparent loss of most editor functionality.
Priority: P3 → P2
Whiteboard: [nsbeta3+]
Target Milestone: --- → M18
My linux build still exits to shell when I bring up a dialog...
Status: NEW → ASSIGNED
All of the dialogs exit to shell on a fresh build from tonight.

Seems like the workaround is to click in the window to return focus to it.  That
makes this not a P2.  Setting PDTP3.
Priority: P2 → P3
Whiteboard: [nsbeta3+] → [nsbeta3+][pdtp3]
Target Milestone: M18 → Future
Removing PDTP3 for retriage.  P2 category states: "High profile functionality,
Obscure work around exists"  This is certainly very high profile, since all
editor functions silently fail.  The workaround may be obvious to developers,
but I think most people would consider it obscure, if they ever found it,
especially those who stick to the keyboard interface (remember, this is an editor).
Priority: P3 → P2
Whiteboard: [nsbeta3+][pdtp3] → [nsbeta3+]
Target Milestone: Future → M18
pdt claims that clicking is easily discovered.  Please come to the pdt in person 
for any further discussion.  pdtp3.
Priority: P2 → P3
Whiteboard: [nsbeta3+] → [nsbeta3+][pdtp3]
Target Milestone: M18 → Future
nsbeta3-, nominate for rtm
Keywords: rtm
Summary: editor does not regain focus after dialog is dismissed.(Linux) → Editor does not regain focus after dialog is dismissed.(Linux)
Whiteboard: [nsbeta3+][pdtp3] → [nsbeta3-][pdtp3]
I think I get it, and can a=brendan@mozilla.org in lieu of blizzard, who is
traveling back east.  He'll beat me up if I've approved wrongly, but it looks ok
(great galloping global thread-unsafe state variables, batman!).

/be
Testing with 09_20_08 build on Linux.

Let's say I want to insert an 'image' and instead, in error, I click on 'link', 
I cancel out of the dialog box and go right back to the 'Insert' menu item. I 
click on 'Insert' and it gives me the dropdown menu so I assume I can select 
another item. I click on 'image' - nothing happens. In this instance, it is not 
intuitive that I should have gone back and clicked in the document. 
let me give another example for you to ponder:
1. go to the additional comments section of this bug and enter some text
2. select Edit|Preferences (just so a dialog comes up), hit cancel
3. go back to the additional comments section, (do not use your mouse) the
cursor is flashing at the insertion point
4. so continue to type -- does anything happen?

as a novice user -- how would I know that I have to reselect the insertion spot?
Especially if the cursor is flashing at me?

Peter, I am removing the status whiteboard content so this can be reconsidered
by you and pdt
Priority: P3 → P1
Whiteboard: [nsbeta3-][pdtp3]
Target Milestone: Future → ---
Thanks Beth. :-) I was hoping you'd have a chance to add your thoughts.  PDT,
please consider also that Chris had already developed a good fix before this bug
was downgraded, and it has passed a super-review.

I'd go P2 on this bug, but not P1. Marking as such.
Priority: P1 → P2
Whiteboard: [nsbeta3+][PDTP2]
Excellent... fixed.

setting fixed this time...
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
reassigning to blizzard as per his request.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
reassign to blizzard
Assignee: saari → blizzard
Status: REOPENED → NEW
*** Bug 54215 has been marked as a duplicate of this bug. ***
Not holding PR3 for this one, but should fix for RTM -- already has rtm keyword
Whiteboard: [nsbeta3+][PDTP2] → [nsbeta3-][PDTP2]
rtm+
Whiteboard: [nsbeta3-][PDTP2] → [nsbeta3-][PDTP2][rtm+]
PDT marking [rtm need info] since patch and code reviews are not yet available.
Whiteboard: [nsbeta3-][PDTP2][rtm+] → [nsbeta3-][PDTP2][rtm need info]
This is now certainly dead in the water (no comments for 22 days now!), and
should be moved off of the rtm radar.

Well, I should have stayed on top of this, but I didn't.

... but, mystery-fix, this is working for me with 2000102408 MN6 branch Linux 
Marking WORKSFORME. qa->sujay to verify.
Status: NEW → RESOLVED
Closed: 23 years ago → 23 years ago
QA Contact: jrgm → sujay
Resolution: --- → WORKSFORME
verified in 10/24 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.