530196 - Using a symlinked greDir fails to launch application from nsXULStub

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

A xulrunner-stub based application where the GRE (xulrunner) is on a symlinked folder will fail to launch. I have not been able to find the exact place the failure occurs. But I have a simple patch to fix the problem. The patch simply resolves the symlink in the stub before initializing XPCOM.

I have an strace log of a failed launch, but nothing jumps out at me:

https://people.mozilla.com/~mfinkle/fennec/profiles/strace1.log

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

blocks a fennec blocker

Comment 2

[Benjamin Smedberg]

Comment on attachment 413708 [details] [diff] [review]
patch

>diff --git a/xulrunner/stub/nsXULStub.cpp b/xulrunner/stub/nsXULStub.cpp

>+#ifdef MOZ_PLATFORM_HILDON
>+    // Using a symlinked greDir will fail during startup. Not sure why, but if
>+    // we resolve the symlink, everything works as expected.
>+    char resolved_greDir[MAXPATHLEN] = "";  
>+    if (realpath(greDir, resolved_greDir) && strlen(resolved_greDir) > 0) {
>+      strncpy(greDir, resolved_greDir, MAXPATHLEN);
>+    }
>+#endif

Is there any particular reason this should be HILDON-only? Please do this for all XP_UNIX unless there's a reason not to.

In any case, the simpler way to say "strlen(resolve_greDir) > 0" is "*resolve_greDir"

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #2)
> (From update of attachment 413708 [details] [diff] [review])
> >diff --git a/xulrunner/stub/nsXULStub.cpp b/xulrunner/stub/nsXULStub.cpp

> Is there any particular reason this should be HILDON-only? Please do this for
> all XP_UNIX unless there's a reason not to.

No reason. I was just being conservative. Changed to XP_UNIX.

> In any case, the simpler way to say "strlen(resolve_greDir) > 0" is
> "*resolve_greDir"

Changed

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

Patch with review changes

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mozilla-central/rev/41c1b69b3ed3

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed m-192:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/e7dfac59fa7c