530235 - Windows "Recent Documents" and Privacy (private browsing, clear recent history)

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

This is a follow up bug from bug 528416 comment # 11, where sdwilsh notes that we control the entries in the Window's Recent Documents menu.

When we are in private browsing mode, we should be sure to never add anything to the Recent Documents menu.  Additionaly if we actually have the ability to remove entries (and not just control what we add) we should remove any entries that we added based on the time range of a Clear Recent History operation.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Should be pretty easy to add a mInPrivateBrowsing check to nsDownload::SetState before the call to SHAddToRecentDocs.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

(nsDownloadManager::gDownloadManagerService->mInPrivateBrowsing, I guess)

Comment 3

[(no longer active)]

Attachment: Patch (v1)

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 422467 [details] [diff] [review]
Patch (v1)

I guess writing a test for this would be rather tricky given our troubles with test_bug_401430.js... I take it you've tested it manually, though :)

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 422467 [details] [diff] [review]
Patch (v1)

ui-r+ based on described functionality

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/984c67bbd6c1

Comment 7

[(no longer active)]

(In reply to comment #4)
> (From update of attachment 422467 [details] [diff] [review])
> I guess writing a test for this would be rather tricky given our troubles with
> test_bug_401430.js... I take it you've tested it manually, though :)

Yes, that is why I didn't write a test for it.