530261 - "This forum is flat and doesn't allow replies to other replies" article shouldn't be indexed

Status: VERIFIED FIXED

Description

[Stephen Donner [:stephend]]

(BTW, seems like pagination is screwed up again?)

STR:

1. Load http://support-stage.mozilla.org/search.php?locale=en-US&q=clear+history&lang=en&where=all (search for "Clear history" from the homepage)
2. Click on the "4" pagination (http://support-stage.mozilla.org/search.php?locale=en-US&q=clear+history&lang=en&where=all&offset=30)
3. Scroll down to the bottom article and click on it

Actual Results:

It loads http://support-stage.mozilla.org/en-US/forum/1/3864?s=clear%20history, which says "Error

This forum is flat and doesn't allow replies to other replies"

Expected Results:

Guessing this at least shouldn't be indexed (don't know what's wrong with it in the 1st place, though)

Comment 1

[James Socol [:jsocol, :james]]

It should be indexed, but it's pointing to a reply instead of to the thread itself.

Comment 2

[Paul Craciunoiu [:paulc]]

This happened to me locally when the indexer wasn't in sync with the database.

When using where=all, search results get formatted based on an offset, whether they come from the forum or the KB. I'm guessing 3864 was actually a wiki article. It is also possible that the offset is calculated wrong. I can't reproduce this locally with my old db though.

Comment 3

[James Socol [:jsocol, :james]]

I did not see this after applying the patch to bug 530668.

Comment 4

[Paul Craciunoiu [:paulc]]

Stephen, can you take a look? If Stephen confirms, feel free to close this bug James.

Comment 5

[Stephen Donner [:stephend]]

Yeah, I no longer see this with the patch from bug 530668.

Comment 6

[Stephen Donner [:stephend]]

Verified FIXED.