Closed Bug 530300 Opened 13 years ago Closed 13 years ago

Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX in /dom

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla1.9.3a2

People

(Reporter: lusian, Assigned: lusian)

References

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091120 Minefield/3.7a1pre (.NET CLR 3.5.30729)
Build Identifier: 

Please see Bug #512106.

Reproducible: Always
Blocks: 518502
OS: Windows XP → All
Hardware: x86 → All
Version: unspecified → Trunk
Attached patch Search&Replace, 0 (obsolete) — Splinter Review
Attachment #413817 - Flags: review?(peterv)
Assignee: nobody → lusian
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
diff --git a/dom/src/json/test/unit/json2.js b/dom/src/json/test/unit/json2.js
--- a/dom/src/json/test/unit/json2.js
+++ b/dom/src/json/test/unit/json2.js
@@ -340,16 +340,19 @@ if (!this.crockfordJSON) {
 // Join all of the member texts together, separated with commas,
 // and wrap them in braces.
 
             v = partial.length === 0 ? '{}' :
                 gap ? '{\n' + gap + partial.join(',\n' + gap) + '\n' +
                         mind + '}' : '{' + partial.join(',') + '}';
             gap = mind;
             return v;
+
+	default:
+	    throw new Error("str: Invalid type " + value);

Drive-by comment: was this intentional?
I was trying to make xpcshell-tests strict legal, and json2.js caused failures on the JavaScript strict mode (TypeError: function str does not always return a value).  I added the default case after reading the review commment: https://bugzilla.mozilla.org/show_bug.cgi?id=524781#c14
Comment on attachment 413817 [details] [diff] [review]
Search&Replace, 0

Please remove the json2.js change if it's not related to this bug.
Attachment #413817 - Flags: review?(peterv) → review+
Sorry for json2; it shouldn't be there.
Attachment #413817 - Attachment is obsolete: true
Keywords: checkin-needed
Attachment #426689 - Attachment is patch: true
Attachment #426689 - Attachment mime type: application/octet-stream → text/plain
http://hg.mozilla.org/mozilla-central/rev/f8a43ae32718

Thanks!
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.