530300 - Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX in /dom

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jae-Seong Lee-Russo]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091120 Minefield/3.7a1pre (.NET CLR 3.5.30729)
Build Identifier: 

Please see Bug #512106.

Reproducible: Always

Comment 1

[Jae-Seong Lee-Russo]

Attachment: Search&Replace, 0

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

diff --git a/dom/src/json/test/unit/json2.js b/dom/src/json/test/unit/json2.js
--- a/dom/src/json/test/unit/json2.js
+++ b/dom/src/json/test/unit/json2.js
@@ -340,16 +340,19 @@ if (!this.crockfordJSON) {
 // Join all of the member texts together, separated with commas,
 // and wrap them in braces.
 
             v = partial.length === 0 ? '{}' :
                 gap ? '{\n' + gap + partial.join(',\n' + gap) + '\n' +
                         mind + '}' : '{' + partial.join(',') + '}';
             gap = mind;
             return v;
+
+	default:
+	    throw new Error("str: Invalid type " + value);

Drive-by comment: was this intentional?

Comment 3

[Jae-Seong Lee-Russo]

I was trying to make xpcshell-tests strict legal, and json2.js caused failures on the JavaScript strict mode (TypeError: function str does not always return a value).  I added the default case after reading the review commment: https://bugzilla.mozilla.org/show_bug.cgi?id=524781#c14

Comment 4

[Peter Van der Beken [:peterv]]

Comment on attachment 413817 [details] [diff] [review]
Search&Replace, 0

Please remove the json2.js change if it's not related to this bug.

Comment 5

[Jae-Seong Lee-Russo]

Attachment: updated, chekin please

Sorry for json2; it shouldn't be there.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/f8a43ae32718

Thanks!