TestXREMakeCommandLineWin.cpp compilation fails on mingw due to unsupported wmain

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Toolkit
Startup and Profile System
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

unspecified
mozilla1.9.3a1
x86
Windows XP
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 413826 [details] [diff] [review]
fix

The bug is similar to bug 411826. I've copied the solution and the test compiles and successes for me.
(Assignee)

Updated

9 years ago
Attachment #413826 - Attachment is patch: true
Attachment #413826 - Flags: review?(ted.mielczarek)
Actually, this is a startup bug that was found by one of the consumers (app update) of this code.
Component: Application Update → Startup and Profile System
QA Contact: application.update → startup
Summary: estXREMakeCommandLineWin.cpp compilation fails on mingw due to unsupported wmain → TestXREMakeCommandLineWin.cpp compilation fails on mingw due to unsupported wmain
Assignee: nobody → jacek
Comment on attachment 413826 [details] [diff] [review]
fix

This is fine, but if we're going to wind up with this code copy & pasted in more places we should get it into a header file or something eventually.
Attachment #413826 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 3

9 years ago
Thanks for review. I will think about it if I will have to copy&paste it again.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/929bce835cdb
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.