Closed
Bug 53036
Opened 24 years ago
Closed 24 years ago
Dual menubutton mouseover niggles
Categories
(SeaMonkey :: Themes, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.8.1
People
(Reporter: neil, Assigned: hewitt)
Details
(Keywords: classic)
Attachments
(1 file)
2.85 KB,
patch
|
Details | Diff | Splinter Review |
Looks as if the active effect isn't getting set properly.
Try this with an enabled back or forward button:
1. Mouse over [hover]
2. Mouse down [active]
3. Mouse out [normal]
4. Mouse up
5. Mouse over [hover]
Expected results: borders show hover effect only
Actual results: dropmarker shows active effect
1. Mouse over [hover]
2. Mouse down [active]
3. Mouse out [normal]
4. Mouse over [active]
5. Mouse out [normal]
6. Mouse over [active]
Expected results: borders show active effect
Actual results: dropmarker shows hover effect
Reporter | ||
Comment 2•24 years ago
|
||
Silly me, I mean Windows Classic.
Reporter | ||
Comment 3•24 years ago
|
||
This has been nearly fixed.
The problems with the borders have been fixed.
However, the dropmarkers are still moving in case 1 and not in case 2.
Also, there's a new problem.
Right-click on the button. Release. Mouse out. Result: dropmarker active effect.
Sending to Joe, ccing Ben.
Assignee: hangas → hewitt
Keywords: classic
Assignee | ||
Comment 5•24 years ago
|
||
Sending to Ben because I believe he's been working on the toolbar menubutton
problems in classic.
Assignee: hewitt → ben
Assignee | ||
Comment 6•24 years ago
|
||
taking
Assignee: ben → hewitt
Priority: P3 → P4
Summary: Dual menubutton mouseover niggles → [Classic] Dual menubutton mouseover niggles
Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•24 years ago
|
||
Assignee | ||
Comment 8•24 years ago
|
||
This bug exists because of the way dual menubuttons capture mouse events on
their internal button and set attributes to indicate the mouse over/down state.
The reason for the first part of this bug was that onmouseup was not being
captured at the document level. Therefore, when the mouse was released while
not over the button, and the menubutton was never notified. The cause of the
second part of the bug was just a subtle error in the handler code.
Ben, how about a (super) review for this patch?
r=timeless, although this looks wierd/backwards
+ <property name="_globalMouseUpHandler" readonly="true">
+ <![CDATA[
+ var fn = function(aEvent)
hewitt notes that it isn't meant to be called as a method, which makes sense.
Summary: [Classic] Dual menubutton mouseover niggles → Dual menubutton mouseover niggles
Assignee | ||
Updated•24 years ago
|
Priority: P4 → P3
Target Milestone: --- → mozilla0.8.1
Assignee | ||
Comment 11•24 years ago
|
||
fixed
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 12•24 years ago
|
||
Marking verified on windows (2001-03-19-12-Mtrunk).
Status: RESOLVED → VERIFIED
Updated•17 years ago
|
Product: Core → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•