User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091120 Minefield/3.7a1pre (.NET CLR 3.5.30729) Build Identifier: Please see Bug #512106. Reproducible: Always
Created attachment 413871 [details] [diff] [review] Search&Replace, 0
Attachment #413871 - Flags: review?(smontagu)
Attachment #413871 - Flags: review?(smontagu) → review+
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
From an OS X build: nsUCSupport.cpp /Users/philor/mc/mozilla/intl/uconv/util/nsUCSupport.cpp: In member function ‘void nsBufferDecoderSupport::FillBuffer(const char**, PRInt32)’: /Users/philor/mc/mozilla/intl/uconv/util/nsUCSupport.cpp:110: error: ‘NS_MIN’ was not declared in this scope
Created attachment 417360 [details] [diff] [review] Add #include I have only Windows XP, so I could not test this on other platforms. I included "nsAlgorithm.h" in nsUCSupport.cpp. Will this fix the build error on OS X?
No, according to the tryserver, that breaks all three platforms - nsUnicodeToUTF8.cpp /builds/slave/sendchange-macosx-hg/build/intl/uconv/src/nsUTF8ToUnicode.cpp: In member function 'virtual nsresult nsUTF8ToUnicode::Convert(const char*, PRInt32*, PRUnichar*, PRInt32*)': /builds/slave/sendchange-macosx-hg/build/intl/uconv/src/nsUTF8ToUnicode.cpp:335: error: 'NS_MIN' was not declared in this scope nsUTF8ToUnicode.cpp /builds/slave/sendchange-linux-hg/build/intl/uconv/src/nsUTF8ToUnicode.cpp: In member function ‘virtual nsresult nsUTF8ToUnicode::Convert(const char*, PRInt32*, PRUnichar*, PRInt32*)’: /builds/slave/sendchange-linux-hg/build/intl/uconv/src/nsUTF8ToUnicode.cpp:335: error: ‘NS_MIN’ was not declared in this scope nsUTF8ToUnicode.cpp e:/builds/slave/win32-hg/build/intl/uconv/src/nsUTF8ToUnicode.cpp(335) : error C3861: 'NS_MIN': identifier not found
I updated my tree, did 'hg update -C tip' and applied the 2nd patch (Add #include); the build was successful on my computer (Windows XP), the tryserver says the otherwise, so I am not sure how to test the patches for bugs including this and others that fail on OS X. I think adding #include "nsAlgorithm.h" to files that fail will solve the problem, but is it a good solution?
Fixed by bug 661584.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.