Closed Bug 530393 Opened 12 years ago Closed 12 years ago
Don't build updater code for Maemo
...since we're not using it. This should help Ts.
Changes the "nightly" linux mobile mozconfig. Changes: 1) remove ac_add_options --enable-tests since it's the default 2) --disable-javaxpcom only needs to be specified for xulrunner 3) adds --disable-updater for xulrunner 4) re-orders the file to group xulrunner/mobile options
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #413914 - Flags: review?
Attachment #413914 - Flags: review? → review?(aki)
Comment on attachment 413914 [details] [diff] [review] patch This looks good, but we need to keep the mozilla2-staging copy in sync.
Can I just push this once r+ed, or are there other steps involved that you need to handle?
Comment on attachment 413997 [details] [diff] [review] patch For non-try mozconfigs, you can push them and they'll take effect without further action.
Attachment #413997 - Flags: review?(aki) → review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Post-B5
Gavin, I just downloaded a fennec maemo nightly and it still contains nsUpdateService.js and nsUpdateServiceStub.js which it shouldn't. I verified this works with Firefox when using ac_add_app_options --disable-updater so I am not sure what is going on here.
That's pretty strange... I tested with a local Fennec build on Mac, and ac_add_app_options xulrunner --disable-updater did the trick (neither of those components were produced). Looking at the log of the latest 1.9.2 maemo nightly, I don't see it building either of the update components: http://tinderbox.mozilla.org/showlog.cgi?log=Mobile/1259139605.1259143446.23900.gz&fulltext=1 But those components are indeed included in the current build available from http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mobile-1.9.2/fennec-1.0b6pre.en-US.linux-i686.tar.bz2 Aki, do you have any idea what's up? Are the nightly builds not clobbers?
Nightly builds are clobbers. The tar.bz2 you're pointing at is the linux-i686 (desktop) tarball, which uses the mobile-desktop/ mozconfig rather than the mobile-browser/ mozconfig. So I can see those components being in the desktop builds, or in the tinderbox-builds/ directory, but not in the nightly/ for recent linux-gnueabi-arm tarballs.
(In reply to comment #8) > So I can see those components being in the desktop builds, or in the > tinderbox-builds/ directory, but not in the nightly/ for recent > linux-gnueabi-arm tarballs. Oh, good call. That is indeed the case!
Thanks for straightening me out on this!
Component: Linux/Maemo → General
OS: All → Linux (embedded)
QA Contact: maemo-linux → general
Hardware: All → ARM
You need to log in before you can comment on or make changes to this bug.