530539 - Need to be able to specify nosplash in an environment variable

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Brian Crowder]

This is necessary for restarts because we cannot pass ourselves command-line arguments from components.

Comment 1

[Brian Crowder]

Attachment: If the environment variable exists....

Comment 2

[Brian Crowder]

Comment on attachment 414054 [details] [diff] [review]
If the environment variable exists....

Woops, missed part of this and it needs a tweak.

Comment 3

[Brian Crowder]

Attachment: another spin

Adds the environment variable to the faststartup reboot logic.  Will ask for review after some testing.

Comment 4

[Brian Crowder]

Comment on attachment 416124 [details] [diff] [review]
another spin

This works well.

Comment 5

[Justin Dolske [:Dolske]]

Comment on attachment 416124 [details] [diff] [review]
another spin

I probably would have written

isNoSplash |= (PR_GetEnv("NO_SPLASH") != 0);

as

if (...envvar set...)
  isNoSplash = true;

but it's fine as is.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/0848e0bf9e9d

Comment 8

[Brian Crowder]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/4289e7a61d2f

Comment 9

[Brian Crowder]

That last revision was accidentally landed against the relbranch.  It doesn't seem necessary to backout, so I am leaving it there unless it causes trouble.  I won't land on the default 192 branch until I have explicit approval, since we're nearing an endgame for both Fx3.6 and the Maemo release of Fennec.

Comment 10

[Brian Crowder]

Disregard; after discussion on IRC I've landed on the default 192 as well:

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/b2d20792890a

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 416124 [details] [diff] [review]
another spin

looks like this already landed, clearing the approval request flag