Closed Bug 530654 Opened 15 years ago Closed 15 years ago

Full-screen video closes immediately on OS X

Categories

(Toolkit :: Video/Audio Controls, defect)

Product:
Toolkit
Component:
Video/Audio Controls
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.3a1
Tracking Flags:
Tracking Status
status1.9.2 --- beta5-fixed

People

(Reporter: ehsan.akhgari, Assigned: dao)

References

Details

(Keywords: regression, verified1.9.2)

Attachments

(1 file)

possible patch
1.25 KB, patch
Gavin
: review+
Details | Diff | Splinter Review 
STR:

1. Open any ogg video, such as http://tinyvid.tv/show/2c256qayaokq3
2. Go to full-screen mode.

It opens up a full-screen window and dismisses it quickly, and stops the video on the original page if it's playing.
Keywords: regressionwindow-wanted
This is now visible on branch builds, though it wasn't when Ehsan reported it, so it's obviously in something that landed on 1.9.2 in the past couple of days.
Flags: blocking1.9.2+
Summary: Full-screen video playback broken on trunk → Full-screen video playback broken
This should be a rough regression range: <http://hg.mozilla.org/releases/mozilla-1.9.2/pushloghtml?fromchange=88014ded05dc&tochange=afd98d2e9977>

The only obvious video related change here is bug 521129.
Seems to be a mac-specific quirk. I don't see why we would get the deactivate event initially.
Blocks: 521129
Keywords: regressionwindow-wanted
Assignee: nobody → dao
Was fine in yesterday's nightly, broken in todays. Here's updated regression range based on those buildconfigs. 

http://hg.mozilla.org/releases/mozilla-1.9.2/pushloghtml?fromchange=e7dfac59fa7c&tochange=1206cbcdd06e

Bug 521129 landed in there making it all the more likely.
Summary: Full-screen video playback broken → Full-screen video closes immediately on OS X
Attached patch possible patch — — Splinter Review 
can someone on OS X please try this?
Comment on attachment 414591 [details] [diff] [review]
possible patch

this indeed fixes it.
Attachment #414591 - Flags: review+
This is also exiting full screen immediately for me on Fx3.6 beta 4 build.  i was trying on de.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; de; rv:1.9.2b4) Gecko/20091124 Firefox/3.6b4
http://hg.mozilla.org/mozilla-central/rev/f49658bb1655
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/2c00dc29960a
Status: NEW → RESOLVED
Closed: 15 years ago
status1.9.2: --- → final-fixed
Resolution: --- → FIXED
Whiteboard: [needs landing]
Verfied on trunk and 1.9.1 with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091126 Minefield/3.7a1pre ID:20091126031020

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b5pre) Gecko/20091126 Namoroka/3.6b5pre ID:20091126033851
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
Keywords: verified1.9.2
Hardware: x86 → All
Target Milestone: --- → mozilla1.9.3a1
Component: Video/Audio → Video/Audio Controls
Product: Core → Toolkit
QA Contact: video.audio → video.audio
Target Milestone: mozilla1.9.3a1 → ---
Version: Trunk → unspecified
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: