530662 - Installation countdown does not work for theme installations due to redirect

Status: VERIFIED WORKSFORME

(addons.mozilla.org Graveyard :: Public Pages, defect, P5)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5pre) Gecko/20091102 Shiretoko/3.5.5pre

Probably due to a latest update for AMO we have a regression for installing a theme under certain conditions. When users try to install a theme and click on the install button the installation warning dialog pops-up but the counter doesn't decrement. You have to explicitly click the timer button.

As what I can see is that we start a redirect when clicking the installation button on the AMO website.

https://addons.mozilla.org/en-US/firefox/addon/122 =>
https://addons.mozilla.org/en-US/firefox/addon/122/developers/post_install?confirmed=true

With that redirect the focus is probably removed from the installation warning dialog. And the timer only works when the dialog has focus. How serious is this issue? I can reproduce it on all platforms with the following steps:

1. Start Shiretoko and load https://addons.mozilla.org/en-US/firefox/addon/122
2. Click the green installation button
3. Wait and check that the timer doesn't decrease

I'm not sure which component I have to use right now. So placing this into Add-ons Manager for now.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Screencast can be found here: http://screencast.com/t/ZTAyZjE4YzYt

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Screencast can be found here: http://screencast.com/t/ZTAyZjE4YzYt

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sorry for the mess. I'm fighting with mid-airs. :/

Just one more note. The redirect does not happen for installations of extensions. It's theme only.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Why do we need this redirect for themes? CC'ing Wil.

For me it looks like two separate bugs. One for the redirect and the other one for the focus loss. The latter one is probably already fixed on 1.9.2.

Comment 5

[Wil Clouser [:clouserw]]

The redirect is because they've set the option to show the "meet the dev" page after install.

That said, I can't reproduce the problem.  It wfm.

Comment 6

[Fred Wenzel [:wenzel]]

I also can't reproduce, neither with Fx 3.6b3 nor with a (3.7) trunk build. Both on OSX, though. Is this platform-specific?

Comment 7

[Wil Clouser [:clouserw]]

comment 0 says linux (and I was on linux) but the screencast looks like OS X.  Either way, we can't reproduce this.  Perhaps try it on a clean profile?

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As I have said this problem is only present for Firefox 3.5 builds. It's not visible for any Namoroka or Minefield build. And it happens on all platforms. When you load https://addons.mozilla.org/en-US/firefox/addon/122 click the "Add to Firefox" button and wait - don't click install! Once the redirect happened the focus is removed and the countdown button is greyed out and shows 5s.

I have setup a new XP machine under VM3 and the issue is promptly reproducible.

Comment 9

[Dave Townsend [:mossop]]

This bug is not something we'd really work on in the Firefox code unless it was blocking1.9.0.x (and I don't believe it should be). So this should either be handled on AMO's side or it's a wontfix.

Comment 10

[Fred Wenzel [:wenzel]]

IIRC, the install process has a post-install callback that we could use to forward the user iff they actually installed the add-on, not right when they click the button. Added benefit: Clicking cancel takes you back to the add-on page you came from, not to the donation page.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That sounds like a good solution. I'll move it over to AMO. It's up to you now.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Jeff, which check-in has been fixed this problem in which version of AMO? Looks fine so far even on the public page.

Comment 13

[Jeff Balogh (:jbalogh)]

(In reply to comment #12)
> Jeff, which check-in has been fixed this problem in which version of AMO? Looks
> fine so far even on the public page.

I have no idea.  It happened when we switched themes to zamboni.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Ok. So lets call it WFM then.