530692 - Selecting a canned response shouldn't delete text in comments box

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P2)

Description

[Jorge Villalobos [:jorgev] (he/him)]

Some add-ons require very elaborate responses, detailing several different kinds of errors or corrections the author needs to make. It'd be great that it is possible to add several canned responses in a single comment without having to resort to copy/paste tricks.

I think it's best that choosing a canned response inserts the text into wherever the cursor happens to be, instead of clearing the textbox completely.

Comment 1

[Scott McCammon [:mccammos]]

Attachment: Fix

Comment 2

[Wil Clouser [:clouserw]]

Comment on attachment 416197 [details] [diff] [review]
Fix

wait until 5.5 to commit

Comment 3

[Scott McCammon [:mccammos]]

r57649

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/editors/review/73847; I typed "o hai" and then selected a canned response, and it concatenated the two strings, rather than replacing "o hai".

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...