530708 - Socorro UI - Disallowed key characters in global data.

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[K Lars Lohn [:lars] [:klohn]]

when attempting to drill down from a search page to a list of crashes, I get a page that says: "Disallowed key characters in global data." and nothing more.

reproduced with this URL: 
https://crash-stats.mozilla.com/report/list?product=Firefox&version=Firefox:3.5.5&query_search=signature&query_type=exact&query=&date=&range_value=1&range_unit=weeks&do_query=1&signature=nsCOMPtr_base::assign_from_qi%28nsQueryInterface,%20nsID%20const&%29&page=1

Comment 1

[Austin King [:ozten]]

Can you list exact repro steps?

The url above isn't url encoded properly. It should look like:
https://crash-stats.mozilla.com/report/list?product=Firefox&version=Firefox:3.5.5&query_search=signature&query_type=exact&query=&date=&range_value=1&range_unit=weeks&do_query=1&signature=nsCOMPtr_base%3A%3Aassign_from_qi(nsQueryInterface%2C%20nsID%20const%26)&page=1

I did the following and was unable to repro your issue:
1) Got to homepage
2) Search product=Firefox version=3.5.5, adv search exact signature=nsCOMPtr_base::assign_from_qi(nsQueryInterface, nsID const&)
3) Click Filter button
4) Click only link in query results
5) Viewing report/list - seeing all crashes

Comment 2

[K Lars Lohn [:lars] [:klohn]]

eh, I think we've lost it.  

I just did a simple query for FF3.5.5.  In the query results, at about position 95, I found the signature I needed and clicked on it.  That's when I got the "Disallowed..." message.  I clicked the back button, and right clicked the offending link and saved the link destination to the clipboard.  I pasted it directly into the url line and got the same "Disallowed..." message.  I clicked on several other links from the original search results and found them working properly.  

I then wrote the bug report, and pasted the offending url into the report.

I am not now able to reproduce this problem.

Comment 3

[K Lars Lohn [:lars] [:klohn]]

this problem has cropped up again, here's how I'm able to reproduce it. 

This query: 

http://crash-stats.mozilla.com/query/query?product=Firefox&version=Firefox%3A3.7a1pre&date=11%2F27%2F09&range_value=4&range_unit=days&query_search=signature&query_type=startswith&query=nsCOMPtr_base&do_query=1

The link in the first search result is:

https://crash-stats.mozilla.com/report/list?product=Firefox&version=Firefox:3.7a1pre&query_search=signature&query_type=startswith&query=nsCOMPtr_base&date=11/27/09&range_value=4&range_unit=days&do_query=1&signature=nsCOMPtr_base::assign_from_qi%28nsQueryInterface,%20nsID%20const&%29&page=1

clicking that link gives the page that simply states:

Disallowed key characters in global data.

Comment 4

[Austin King [:ozten]]

Yes! I've figure this issue out.

It only happends if your logged in and on a non-secure page. The query string parameters weren't getting encoded properly for the path we use to do the secure redirect.

Repro'd in stage and verified the fix.

r1555.