530739 - Intermittent Shutdown crash after visiting a page with flash video

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Doug Turner (:dougt)]

We are seeing a shutdown crash after visiting a page with flash video.  No stack trace yet.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 414556 [details] [diff] [review]
patch v.1


> DoDelayedStop(nsPluginInstanceOwner *aInstanceOwner, PRBool aDelayedStop)
> {
>+#ifdef MOZ_PLATFORM_HILDON
>+  // Don't delay stop on Maemo/Hildon (bug 530739).
>+  if (aInstanceOwner->MatchPluginName("Shockwave Flash"))
>+    return PR_FALSE;
>+#endif

Do you want to test for aDelayedStop here too? Like the code below does.
>+
>   // Don't delay stopping QuickTime (bug 425157), Flip4Mac (bug 426524),
>   // XStandard (bug 430219), CMISS Zinc (bug 429604).
>   if (aDelayedStop
> #if !(defined XP_WIN || defined MOZ_X11)
>       && !aInstanceOwner->MatchPluginName("QuickTime")

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 414556 [details] [diff] [review]
patch v.1

r=jst wiht mfinkle's suggested change.

Comment 4

[Doug Turner (:dougt)]

Comment on attachment 414556 [details] [diff] [review]
patch v.1

http://hg.mozilla.org/mozilla-central/rev/d2c981b11f92

Comment 5

[Doug Turner (:dougt)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/4bb1ebd76779