530889 - Shutdown FastStart service

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Alex Pakhotin (:alexp)]

When the FastStart service is enabled, it's always running and there is no way to shut it down.

Comment 1

[Alex Pakhotin (:alexp)]

Attachment: Patch to handle -shutdown-faststart flag

Shut down FastStart service when -shutdown-faststart command line flag is provided.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 414356 [details] [diff] [review]
Patch to handle -shutdown-faststart flag


>+
>+    if (cmdLine.handleFlag("shutdown-faststart", false)) {
>+      // Shutdown this service
>+      let appstartup = Cc["@mozilla.org/toolkit/app-startup;1"].getService(Ci.nsIAppStartup);
>+      appstartup.quit(Ci.nsIAppStartup.eAttemptQuit);

Add a cmdLine.preventDefault = true; here so other commandline handlers are skipped

Comment 3

[Alex Pakhotin (:alexp)]

Attachment: Patch to handle -shutdown-faststart flag

Added "cmdLine.preventDefault = true;"

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/6c225b5a023f

Comment 5

[Brian Crowder]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/6f92e9608204

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED on build:
Mozilla/5.0 (Windows; U; Window3sCE 5.2; en-US; rv:1.9.2b5pre) Gecko/20091202 Namoroka/3.6b5pre Fennec/1.0a4pre