Closed Bug 530906 Opened 15 years ago Closed 15 years ago

random orange: timeout while running browser_privatebrowsing_certexceptionsui.js

Categories

(Firefox :: Private Browsing, defect)

Product:
Firefox
Component:
Private Browsing
Version:
3.6 Branch
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 3.7a1
Tracking Flags:
Tracking Status
status1.9.2 --- beta5-fixed

People

(Reporter: dbaron, Assigned: dao)

References

Details

(Keywords: intermittent-failure, Whiteboard: [test which aborts the suite])

Attachments

(1 file)

fix?
4.58 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review 
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.6-Unittest/1259092413.1259096147.10691.gz
Linux mozilla-1.9.2 test everythingelse on 2009/11/24 11:53:33
s: moz2-linux-slave13



Running chrome://mochikit/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_certexceptionsui.js...
TEST-PASS | chrome://mochikit/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_certexceptionsui.js | The certificate information should be available now
TEST-PASS | chrome://mochikit/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_certexceptionsui.js | the permanent checkbox should be disabled when handling the private browsing mode
TEST-PASS | chrome://mochikit/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_certexceptionsui.js | the permanent checkbox should not be checked when handling the private browsing mode
TEST-INFO | chrome://mochikit/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_certexceptionsui.js | Console message: [JavaScript Error: "Attempted to connect to a site with a bad certificate in the add exception dialog. This results in a (mostly harmless) exception being thrown. Logged for information purposes only: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIXMLHttpRequest.send]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://pippki/content/exceptionDialog.js :: checkCert :: line 167"  data: no]" {file: "chrome://pippki/content/exceptionDialog.js" line: 175}]
TEST-PASS | chrome://mochikit/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_certexceptionsui.js | The certificate information should be available now
TEST-PASS | chrome://mochikit/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_certexceptionsui.js | the permanent checkbox should not be disabled when not handling the private browsing mode
TEST-PASS | chrome://mochikit/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_certexceptionsui.js | the permanent checkbox should be checked when not handling the private browsing mode
TEST-INFO | chrome://mochikit/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_certexceptionsui.js | Console message: [JavaScript Error: "Attempted to connect to a site with a bad certificate in the add exception dialog. This results in a (mostly harmless) exception being thrown. Logged for information purposes only: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIXMLHttpRequest.send]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://pippki/content/exceptionDialog.js :: checkCert :: line 167"  data: no]" {file: "chrome://pippki/content/exceptionDialog.js" line: 175}]
TEST-INFO | chrome://mochikit/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_certexceptionsui.js | Console message:
Waiting for window activation...

command timed out: 1200 seconds without output, killing pid 25435
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox3.6-Unittest/1259123593.1259127182.2752.gz
Linux mozilla-1.9.2 test everythingelse on 2009/11/24 20:33:13  
s: moz2-linux-slave02
I suspect ehsan stalks this component, but just in case...
Attached patch fix? — — Splinter Review 
This removes the known-to-be-fragile window-watcher dependency. There's no good reason for the dialogs to be modal in this test, is there?
Attachment #414518 - Flags: review?(ehsan.akhgari)
Comment on attachment 414518 [details] [diff] [review]
fix?

(In reply to comment #4)
> This removes the known-to-be-fragile window-watcher dependency. There's no good
> reason for the dialogs to be modal in this test, is there?

Not really; I just wanted things to be as similar to the real use case as possible, but I guess it doesn't affect the behavior that we're testing at all.

The patch looks reasonable, and I think we should try it.  Thanks for working on it!
Attachment #414518 - Flags: review?(ehsan.akhgari) → review+
Assignee: nobody → dao
Whiteboard: [orange][test which aborts the suite] → [orange][test which aborts the suite][needs landing]
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1259190927.1259196010.17799.gz
Linux mozilla-central opt test everythingelse on 2009/11/25 15:15:27
s: moz2-linux-slave12
http://hg.mozilla.org/mozilla-central/rev/157ea3970b73
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/237dccbcb967
Status: NEW → RESOLVED
Closed: 15 years ago
status1.9.2: --- → final-fixed
Resolution: --- → FIXED
Whiteboard: [orange][test which aborts the suite][needs landing] → [orange][test which aborts the suite]
Target Milestone: --- → Firefox 3.7a1
Whiteboard: [orange][test which aborts the suite] → [test which aborts the suite]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: