530925 - need immediate feedback on "connect" button when no internet connection

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Madhava Enros [:madhava]]

When you tap on the "Connect" button in Weave options, usually you get feedback because the button greys and the line label changes from "Disconnected" to "Connecting".

It looks like this only works when you're connected to the internet, so that a connection can proceed.  When you're not connected to the internet, the "connect" button doesn't grey out -- it just reverts to it's regular unpressed state.  Because of this, it feels like you just haven't managed to press it.

We should change something, so that there's immediate feedback... maybe grey it while we're trying to do something?  Or, if that's too short, change the row label to "Cannot connect"?

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Fennec now supports an auto-connection feature, but you need to trick gecko into thinking it is online. If you call Util.forceOnline() before attempting a network connection of any kind (including XHR) you should get a "pick a network connection" dialog on the N900/N810.

The Fennec front-end code does this in a few places. See bug 530013

Comment 2

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/b4ebc51df5d6
Use Util.forceOnline() to make sure the user gets something if offline and trying to connect.