530969 - jstests.py doesn't work on X64

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

[ocean:~/moz/ws0/js/src/tests] python jstests.py -j 2 ../debug64/js
Traceback (most recent call last):
  File "jstests.py", line 262, in <module>
    test_list = manifest.parse(OPTIONS.manifest, xul_tester)
  File "/home/njn/moz/ws0/js/src/tests/manifest.py", line 102, in parse
    ans += parse(os.path.join(dir, parts[1]), xul_tester)
  File "/home/njn/moz/ws0/js/src/tests/manifest.py", line 102, in parse
    ans += parse(os.path.join(dir, parts[1]), xul_tester)
  File "/home/njn/moz/ws0/js/src/tests/manifest.py", line 130, in parse
    if xul_tester.test(cond):
  File "/home/njn/moz/ws0/js/src/tests/manifest.py", line 78, in test
    raise Exception("Failed to test XUL condition '%s'"%cond)
Exception: Failed to test XUL condition 'xulRuntime.OS=="Linux"&&xulRuntime.XPCOMABI.match(/x86_64/)'

Comment 1

[David Mandelin [:dmandelin]]

Attachment: Patch

Nick, can you test this patch for me? I'm pretty sure it works but I don't actually have an X64 setup here to test it on.

Comment 2

[David Mandelin [:dmandelin]]

(In reply to comment #1)
> Created an attachment (id=414422) [details]
> Patch
> 
> Nick, can you test this patch for me? I'm pretty sure it works but I don't
> actually have an X64 setup here to test it on.

Nevermind, Jeff just tested it for us, and it works.

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 414422 [details] [diff] [review]
Patch

Works for me too!  Thanks.

Comment 4

[David Mandelin [:dmandelin]]

http://hg.mozilla.org/tracemonkey/rev/da484c48f148

Comment 5

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/da484c48f148