Closed
Bug 530980
Opened 15 years ago
Closed 15 years ago
add a plugin test that sets and then gets a cookie
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: jaas)
References
Details
Attachments
(1 file, 3 obsolete files)
|
8.49 KB,
patch
|
Details | Diff | Splinter Review |
We need to add a plugin test that sets and then gets a cookie. Bug 526462 went uncaught for way too long.
Attachment #414461 -
Flags: review?(roc)
Attachment #414461 -
Flags: review?(roc) → review+
Comment on attachment 414461 [details] [diff] [review] tests v1.0 You probably should have the test check that a cookie was actually set, using document.cookie --- https://developer.mozilla.org/en/DOM/document.cookie
Wouldn't that be redundant? How would the second test which gets the cookie via NPAPI succeed if setting it failed?
updated to tip
Attachment #414461 -
Attachment is obsolete: true
pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/682926ebca13
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
This was in the range for causing a leak, so I backed it out: http://hg.mozilla.org/mozilla-central/rev/653d713874ab and indeed the leak seems to have gone away. Every non-opt test run containing this patch showed the leak. Example: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1260924358.1260925444.26010.gz&fulltext=1 This is pretty scary. It seems that setting and/or getting a cookie via NPAPI leaks!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Leak fix.
Attachment #417725 -
Attachment is obsolete: true
Updated to current trunk.
Attachment #418027 -
Attachment is obsolete: true
|
||
Comment 9•15 years ago
|
||
jgriffin, this is at least part of the test we need for bug 539755
Blocks: 539755
|
Assignee | |
Comment 10•15 years ago
|
||
pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/aefd3131b2d5
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
This appears to be failing on tinderbox http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1263945354.1263947108.11699.gz&fulltext=1
|
|
||
Comment 12•15 years ago
|
||
I landed a followup, http://hg.mozilla.org/mozilla-central/rev/e9c045ce1618 as a temporary measure to get mochitest-ipcplugins green until bug 540776 lands on m-c.
|
|
||
Comment 13•15 years ago
|
||
Backed out the temporary followup: http://hg.mozilla.org/mozilla-central/rev/33b23aeba630
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•