531078 - Selected text background is the wrong color when window is not focused

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

In text areas selected text has a white background when it should be light grey. In regular content selected text has a dark grey background when it should be light grey.

Comment 2

[Markus Stange [:mstange]]

Hmm, ok, the second issue is actually not covered by bug 141007.

Comment 3

[Stefan [:stefanh]]

So we're not using a system color here, instead we're using the same (hardcoded) color for all platforms: https://dxr.mozilla.org/mozilla-central/rev/5e76768327660437bf3486554ad318e4b70276e1/widget/nsXPLookAndFeel.cpp#775

Looking at webkit, it seems they're using the NSColor secondarySelectedControlColor which is lighter:
https://github.com/WebKit/webkit/blob/1f6436eabdb0d90e04bad8af2c9ba50c6b6c8f98/Source/WebCore/rendering/RenderThemeMac.mm#L301

Comment 4

[Stefan [:stefanh]]

Attachment: Use MacOS system color for selected text background in inactive windows

Not sure if it's better to move everything to each platform-specific nsLookAndFeel file instead of the #ifndef... This is a bit more economical, though.

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 8810987 [details] [diff] [review]
Use MacOS system color for selected text background in inactive windows

Review of attachment 8810987 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay, this looks good.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/befc69f2cf27
Use MacOS system color for selected text background in inactive windows. r=mstange.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/befc69f2cf27