531085 - Can't delete user completely in admin interface

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P1)

Description

[Jorge Villalobos [:jorgev] (he/him)]

I'm trying to delete the user in https://addons.mozilla.org/en-US/firefox/admin/users/5032745, but every time I try to delete it, I get this message: "Error deleting user!".

I was able to make the user anonymous, but not delete it. As far as I can tell, the user is not an add-on author, so there shouldn't be any problems deleting it.

Steps to reproduce:
1) Go to https://addons.mozilla.org/en-US/firefox/admin/users/5032745
2) Scroll to the bottom.
3) Choose "Delete user and remove  all their reviews/ratings (must not be an add-on author)" and click on the button.

Result:
Error deleting user!

Expected:
The user is deleted.

I'm giving this bug high priority because this happens to be a serious spammer posting malware links and I can't remove the user because of this bug.

Comment 1

[Wil Clouser [:clouserw]]

(In reply to comment #0)
> I'm giving this bug high priority because this happens to be a serious spammer
> posting malware links and I can't remove the user because of this bug.

Anonymizing the account is going to have the same effect from the spammer's point of view - they won't be able to use the account.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to comment #1)
> Anonymizing the account is going to have the same effect from the spammer's
> point of view - they won't be able to use the account.

True. The real annoyance is having to delete every single review by hand.

Comment 3

[Fred Wenzel [:wenzel]]

Another place with unresolved foreign key dependencies -- I'll fix it in 5.4.

Comment 4

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

Here you are.

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Another test case, if you need it: https://addons.mozilla.org/en-US/firefox/user/5035218

Comment 6

[Jeff Balogh (:jbalogh)]

Comment on attachment 414526 [details] [diff] [review]
Patch, rev. 1

This is a perfect example of why I always rely on German engineering.

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

Removing the reviews from the editor moderation tools made it possible to remove the users (sorry for removing the test cases).

As I mentioned to wenzel, removing the reviews directly wasn't possible either. I don't know if this patch fixes the problem entirely, but we should open a new bug if it doesn't.

Comment 8

[Fred Wenzel [:wenzel]]

(In reply to comment #7)
> As I mentioned to wenzel, removing the reviews directly wasn't possible either.
> I don't know if this patch fixes the problem entirely, but we should open a new
> bug if it doesn't.

Please do.

Comment 9

[Fred Wenzel [:wenzel]]

r56861 and r56862.

Comment 10

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to comment #8)
> (In reply to comment #7)
> > As I mentioned to wenzel, removing the reviews directly wasn't possible either.
> > I don't know if this patch fixes the problem entirely, but we should open a new
> > bug if it doesn't.
> 
> Please do.

See bug 531149.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Headers of successful user deletion

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/admin/users