531164 - Application Launcher Dialog Pops Up on metacafe.com

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b4pre) Gecko/20091125 Firefox/3.6b4pre Fennec/1.0b6pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091125 Firefox/3.7a1pre Fennec/1.0b5

Steps to Reproduce:
1. Go to http://m.metacafe.com
2. Click on any video link. Wait for the page to laod
3. Click on the video's image on that page.

Actual Results:
The application launcher dialog pops up. Screenshot:

http://www.flickr.com/photos/42893104@N04/4134750208/

Expected Results:
After a talk with Stuart, the intended behavior is supposed to have the application load automatically.

Comment 1

[Aakash Desai [:aakashd]]

This is also happening for tel: and mailto: commands.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch always calls the default handler application for every situation. I chose to implement as a ContentDispatchChooser override so we could extend the system in the future. Also, dealing with setting "ask" to false for all protocols seemed like a pain.

I tested this patch using the tel: protocol found in Joel's test page. The dialog no longer appears and the tel: number is sent directly to the dialer app on N900 and N810.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Tested using m.metacafe.com from comment 0. The Media player is launched when you "Open" the file, but it is not played. I don't think the player can load from the command line. We might need to fix the way "Open" works to try and use DBus.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

This patch builds on the first. We now also show a dialog to confirm the user wishes to use an external application to open the link. We allow the user to remember the choice for the given link type.

We still just fallback to the default application handler. We do not allow the user to choose from a list of all handlers. I am not even showing the name of the handler, since the names are crazy stupid - "osso_voip_ui" and "CallUI" for example.

I am also just reusing strings from the platform.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

screenshot http://people.mozilla.com/~mfinkle/fennec/screenshots/fennec-launchapp.png

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 419037 [details] [diff] [review]
patch 2

I think I'd prefer to not offer the checkbox here, given that we don't have UI to reset it.

Comment 7

[Stuart Parmenter]

Comment on attachment 419037 [details] [diff] [review]
patch 2

a=me

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed with requested changes:
https://hg.mozilla.org/mobile-browser/rev/44cf520a5194

Comment 9

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b5pre) Gecko/20091228 Firefox/3.6b5pre Fennec/1.0b6pre

Comment 10

[Aakash Desai [:aakashd]]

OS integration tests in litmus now take care of app dialog issues:

https://litmus.mozilla.org/show_test.cgi?id=11797
https://litmus.mozilla.org/show_test.cgi?id=11798
https://litmus.mozilla.org/show_test.cgi?id=11799