531181 - localized Get themes links are redirecting to en-US/ subdirectory first

Status: VERIFIED FIXED

(Websites Graveyard :: getpersonas.com, defect)

Description

[Tony Chung [:tchung]]

A few localized beta 4 pages are redirecting to the en-US/ subdirectory, instead of the locale itself.  de and ja are two examples.  HOwever, some work fine, like fr. 

Repro:
1) install 3.6 beta 4 ja or de locale (Mozilla/5.0 (X11; U; Linux i686; ja; rv:1.9.2b4) Gecko/20091124 Firefox/3.6b4)
2) go to addons manager > Themes > Get Themes link
3) Verify the Page redirects to a /en-US/%LOCALE%/ page instead of /%LOCALE/ directly.

Direct (fr): 
- http://www.getpersonas.com/fr/gallery/All/Popular
Redirect (ja, de):
- http://www.getpersonas.com/en-US/de/gallery/All/Popular
- http://www.getpersonas.com/en-US/ja/gallery/All/Popular

Expected:
- no redirect to /en-US/

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Yes, this is because GetPersonas.com is not-yet localized: bug 499332.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Also, I don't think this is an AMO bug.

Comment 3

[Tony Chung [:tchung]]

(In reply to comment #1)
> Yes, this is because GetPersonas.com is not-yet localized: bug 499332.

But fr isnt' localized either, yet it redirects there.  I havent checked other locales outside of these, but any reason why fr is an exception so far?

Comment 4

[Tony Chung [:tchung]]

Stephen, am i duping you here?   bug 528318 comment 7.  if so, please dupe for me, thanks!

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #4)
> Stephen, am i duping you here?   bug 528318 comment 7.  if so, please dupe for
> me, thanks!

I'm going to set a dependency here, so we can track this case specifically; thanks.

Comment 6

[Ryan Doherty (:rdoherty)]

Wil: simplest fix is for AMO to redirect to getpersonas.com/gallery/All and let getpersonas.com do the locale detection.

Can this get in ASAP? Looks like it blocks 3.6

Comment 7

[Ryan Doherty (:rdoherty)]

Attachment: v1

this patch removes the locale code from the url, which allows getpersonas.com to detect locale and redirect if it supports it. otherwise it will redirect to en-US.

Comment 8

[Wil Clouser [:clouserw]]

Comment on attachment 421121 [details] [diff] [review]
v1

go for it

Comment 9

[Ryan Doherty (:rdoherty)]

r59540

Comment 10

[Ryan Doherty (:rdoherty)]

For QA:

Changed redirect from AMO to getpersonas.com from:
addons.mozilla.org/%locale%/firefox/getpersonas => 
getpersonas.com/%locale%/gallery/All

to:

addons.mozilla.org/%locale%/firefox/getpersonas => 
getpersonas.com/gallery/All

getpersonas.com will attempt locale detection

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using a Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7 (.NET CLR 3.5.30729) build (Polish is the only ready locale on Personas stage, currently):

http://personas.stage.mozilla.com/

GET / HTTP/1.1
Host: personas.stage.mozilla.com
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7 (.NET CLR 3.5.30729)
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: pl,en-us;q=0.7,en;q=0.3
Accept-Encoding: gzip,deflate
Accept-Charset: ISO-8859-2,utf-8;q=0.7,*;q=0.7
Keep-Alive: 300
Connection: keep-alive
Cookie: __utma=183859642.826027427.1263329930.1263329930.1263329930.1; __utmb=183859642; __utmz=183859642.1263329930.1.1.utmccn=(direct)|utmcsr=(direct)|utmcmd=(none); s_vsn_mozillacom_1=4777731657377; s_sq=%5B%5BB%5D%5D; s_cc=true; __utmc=183859642

HTTP/1.x 302 Found
Server: Apache/2.2.3 (CentOS)
Content-Type: text/html; charset=UTF-8
Date: Tue, 12 Jan 2010 20:58:39 GMT
Location: http://personas.stage.mozilla.com/pl/
Connection: Keep-Alive
X-Powered-By: PHP/5.1.6
X-Cache-Info: not cacheable; response is 302 without expiry time
Content-Length: 0
----------------------------------------------------------
http://personas.stage.mozilla.com/pl/

GET /pl/ HTTP/1.1
Host: personas.stage.mozilla.com
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.1.7) Gecko/20091221 Firefox/3.5.7 (.NET CLR 3.5.30729)
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: pl,en-us;q=0.7,en;q=0.3
Accept-Encoding: gzip,deflate
Accept-Charset: ISO-8859-2,utf-8;q=0.7,*;q=0.7
Keep-Alive: 300
Connection: keep-alive
Cookie: __utma=183859642.826027427.1263329930.1263329930.1263329930.1; __utmb=183859642; __utmz=183859642.1263329930.1.1.utmccn=(direct)|utmcsr=(direct)|utmcmd=(none); s_vsn_mozillacom_1=4777731657377; s_sq=%5B%5BB%5D%5D; s_cc=true; __utmc=183859642