Closed Bug 531224 Opened 12 years ago Closed 12 years ago

TM: associate JS source locations with fragments properly

Categories

(Core :: JavaScript Engine, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: n.nethercote, Assigned: n.nethercote)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

Attached patch patchSplinter Review
jstracer.cpp carefully associates a JavaScript source location (file name/line number) with each compiled code fragment.  Unfortunately it does so after nanojit::compile() is called, when it's too late.

This patch moves the relevant code earlier.  Example output change:

  === Translating LIR fragments into assembly:
  === -- Compile trunk 0x8745d7c: begin
  === -- Compile trunk 0x8745d7c: end

becomes:

  === Translating LIR fragments into assembly:
  === -- Compile trunk 0x8eafd7c /home/njn/moz/SunSpider/tests/3d-cube.js:80: begin
  === -- Compile trunk 0x8eafd7c /home/njn/moz/SunSpider/tests/3d-cube.js:80: end
Attachment #414677 - Flags: review?(graydon)
Summary: TM: associates JS source locations with fragments properly → TM: associate JS source locations with fragments properly
Attachment #414677 - Flags: review?(graydon) → review+
http://hg.mozilla.org/tracemonkey/rev/cb870a6d0e53
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/cb870a6d0e53
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.