Closed
Bug 531224
Opened 16 years ago
Closed 16 years ago
TM: associate JS source locations with fragments properly
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
2.11 KB,
patch
|
graydon
:
review+
|
Details | Diff | Splinter Review |
jstracer.cpp carefully associates a JavaScript source location (file name/line number) with each compiled code fragment. Unfortunately it does so after nanojit::compile() is called, when it's too late.
This patch moves the relevant code earlier. Example output change:
=== Translating LIR fragments into assembly:
=== -- Compile trunk 0x8745d7c: begin
=== -- Compile trunk 0x8745d7c: end
becomes:
=== Translating LIR fragments into assembly:
=== -- Compile trunk 0x8eafd7c /home/njn/moz/SunSpider/tests/3d-cube.js:80: begin
=== -- Compile trunk 0x8eafd7c /home/njn/moz/SunSpider/tests/3d-cube.js:80: end
Attachment #414677 -
Flags: review?(graydon)
| Assignee | ||
Updated•16 years ago
|
Summary: TM: associates JS source locations with fragments properly → TM: associate JS source locations with fragments properly
Updated•16 years ago
|
Attachment #414677 -
Flags: review?(graydon) → review+
| Assignee | ||
Comment 1•16 years ago
|
||
Whiteboard: fixed-in-tracemonkey
| Assignee | ||
Comment 2•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•