Link failure in testplugin on mingw

RESOLVED FIXED in mozilla1.9.3a1

Status

()

defect
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: jacek, Assigned: jacek)

Tracking

Trunk
mozilla1.9.3a1
x86
Other
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

10 years ago
Posted patch fixSplinter Review
nptest_windows.cpp uses pragma to link to msimg32.lib. It's unsupported on mingw. The attached patch moves msimg32 linking to makefile. We could use makefile for mingw and leave pragma for msvc, but the less difference the better IMO.
Assignee

Updated

10 years ago
Attachment #414755 - Attachment is patch: true
Attachment #414755 - Flags: review?(roc)
Assignee

Comment 1

10 years ago
Thanks for the review.
Keywords: checkin-needed
Assignee: nobody → jacek
http://hg.mozilla.org/mozilla-central/rev/b3c1f6691f8e
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.