nanojit: improve int32 and int64 constant generation in X64 backend

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin)

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
This is similar to bug 531324.  But it's a bit trickier, because there are more cases to consider.
(Assignee)

Comment 1

8 years ago
Created attachment 427748 [details] [diff] [review]
patch
Attachment #427748 - Flags: review?(rreitmai)
(Assignee)

Comment 2

8 years ago
The effect of the patch is that 'xor r,r' gets used in more places to generate zero literals.

Comment 3

8 years ago
Comment on attachment 427748 [details] [diff] [review]
patch

Can deprecated_prepResultReg now be removed?
Attachment #427748 - Flags: review?(rreitmai) → review+
(Assignee)

Comment 4

8 years ago
(In reply to comment #3)
> Can deprecated_prepResultReg now be removed?

No.  See bug 535705, bug 535706, bug 535707, bug 535708, bug 535709 and bug 547298.  I have patches reviewed and ready to land for i386 and X64, but ARM, PPC, Sparc and MIPS all still use it and several other deprecated_* functions.

Comment 6

8 years ago
http://hg.mozilla.org/mozilla-central/rev/1adc27b1503d
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey → fixed-in-nanojit, fixed-in-tracemonkey, fixed-in-tamarin
You need to log in before you can comment on or make changes to this bug.