531333 - Update verify doesn't handle file download errors

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Found while testing a 3.0.15 to 3.6b2 major update where we have some locales that aren't available for 3.6b2, and there's an betatest snippet pointing at 3.5.5. The update verify code can download the mar file and 3.0.15 fine but gets a 404 for the 3.6b2 request. Instead of giving up on that update it tries to continue, there's error handling code but it isn't working.

On mac this looks particularly scary:
Using  https://aus2.mozilla.org/update/1/Firefox/3.0.15/2009101600/Darwin_Universal-gcc3/ka/betatest/update.xml?force=1
18:10:07 URL:http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/3.5.5-candidates/build1/update/mac/ka/firefox-3.5.5.complete.mar [18038145/18038145] -> "update/partial.mar" [1]
18:10:20 URL:http://stage.mozilla.org/pub/mozilla.org//firefox/nightly/3.0.15-candidates/build3/firefox-3.0.15.ka.mac.dmg [17944807/17944807] -> "firefox-3.0.15.ka.mac.dmg" [1]
http://stage.mozilla.org/pub/mozilla.org//firefox/nightly/3.6b4-candidates/build1/mac/ka/Firefox%203.6%20Beta%204.dmg:
18:10:21 ERROR 404: Not Found.
FAIL: Could not download source Firefox 3.6 Beta 4.dmg from http://stage.mozilla.org/pub/mozilla.org//firefox/nightly/3.6b4-candidates/build1/mac/ka/Firefox 3.6 Beta 4.dmg
skipping..
mounting downloads/firefox-3.0.15.ka.mac.dmg
"disk3" unmounted.
"disk3" ejected.
mounting downloads/Firefox 3.6 Beta 4.dmg
./verify.sh: line 29: [: too many arguments
./verify.sh: line 31: [: too many arguments
rsync: opendir "//Library/Logs/Console/0" failed: Permission denied (13)
rsync: opendir "//Library/Logs/Console/501" failed: Permission denied (13)
rsync: opendir "//Library/Logs/Console/503" failed: Permission denied (13)
rsync: opendir "//System/Library/User Template/English.lproj/Desktop" failed: Permission denied (13)
...
Somehow it's trying to copy /* :-S

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Fix error handling

Does two things
* passes an error status on to verify.sh, which is diligently checking it
* check for file existence early in the unpack function

Works fine on mac, need to check the other platforms before review.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 414814 [details] [diff] [review]
Fix error handling

Tests fine on linux and win32. Can't find any other use of "status" as a variable in these scripts so shouldn't stomp on other data. FWIW, l10n verify uses common/unpack.sh.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 414814 [details] [diff] [review]
Fix error handling

Why we did even we use 'continue' in the first place? =\

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 414814 [details] [diff] [review]
Fix error handling

http://hg.mozilla.org/build/tools/rev/4ba469cb1bff