531493 - [ACR Extension] "This add-on still works" should be disabled (greyed) when add-on is compatible instead of hidden

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect, P2)

Description

[J]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b4) Gecko/20091124 Firefox/3.6b4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2b4) Gecko/20091124 Firefox/3.6b4

Hi,
When I click on the compatability button for compatabity reporter 0.4 it says that "this add on no longer works". This is on Firefox 3.6.b4 and as far as I know there is no update for compatabity reporter 0.4?

Many thanks 

J

Reproducible: Always

Steps to Reproduce:
1.click on the compatability button for compatabity reporter 0.4 it says that "this add on no longer works"
2.click on the compatability button for compatabity reporter 0.4 it says that "this add on no longer works"
3.click on the compatability button for compatabity reporter 0.4 it says that "this add on no longer works"
Actual Results:  
"this add on no longer works"

Expected Results:  
Not shown that the compatabity reporter 0.4 no longer works

Yes happens with the default theme which is the only theme that i use

Comment 1

[Dave Garrett]

The whole point of the Add-on Compatibility Reporter extension is to report add-ons that no longer work in a newer version. That button has two options, "This add-on no longer works" and "This add-on still works", however the later doesn't show if the add-on already lists compatibility with the current Firefox version. In this instance, ACR 0.4 is compatible so it isn't letting you report that it is for no reason.

I think this looks a little odd and apparently can confuse some users. I think it would be better if the other option was disabled (greyed out) in this case instead of hidden. That's normally how this sort of thing should be handled in the GUI.

Maybe changing the options to be prefaced with "report that" would also be more clear?

Comment 2

[Justin Scott [:fligtar]]

That's a good idea. I've seen a bunch of confusion about the missing option.

For add-ons that are already compatible, instead of hiding the option, we should have a disabled "Marked as compatible by developer" option without the checkmark image.

Comment 3

[Brian King [:kinger]]

(In reply to comment #2)
> For add-ons that are already compatible, instead of hiding the option, we
> should have a disabled "Marked as compatible by developer" option without the
> checkmark image.

Done, r57092. 

Justin, I put a placeholder for the new string in English in each locale. What's the procedure for announcing new strings now?

Comment 4

[Brian King [:kinger]]

Attachment: New drop down item

Here is what it looks like.

Comment 6

[Brian King [:kinger]]

-> Justin for evaluation. See comment 3 and comment 4.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with latest version of the add-on.