531667 - single-locale builds should have matchOS set to false

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Tim Maks van den Broek [:mad_maks]]

Testing the latest Fennec build on linux i noticed that the warranty warning on about:config was not localized

Mozilla/5.0 (X11;U;Linux i686 (x86_64);nl;rv:1.9.2b5pre)
Gecko/20091129 Namoroka/3.6b5pe Fennec/1.0b6pre

using a clean profile.

http://mxr.mozilla.org/l10n-mozilla1.9.2/source/nl/toolkit/chrome/global/config.dtd#41 shows it as localized

Comment 1

[Axel Hecht [:Pike]]

I think this has something to do with our single-locale builds still having an en-US xulrunner, and possibly matchOS still on.

Moving over to fennec.

Comment 2

[Tim Maks van den Broek [:mad_maks]]

set matchOS to false in about:config is the trick, the page is now in dutch (strange that all the UI is in dutch but that that page is looking to the OS)

i think we can close this bug

Comment 3

[Axel Hecht [:Pike]]

We should fix this.

I think we should not set matchOS in the regular builds, but set that as part of mobile-l10n.js for the multi-locale build.

Comment 4

[Axel Hecht [:Pike]]

I don't have a good idea where to hook up a fix for this right now, but it's blocking the release of single locale builds.

Comment 5

[Axel Hecht [:Pike]]

I have a few ideas on how to fix this, the intended outcome of which would be:

- switching off matchOS in single-locale buids
- switching on matchOS in multi-locale builds

Right now, the locale is set in mobile-l10n.js as part of the libs:: phase in locales/Makefile, taken from locales/en-US/mobile-l10n.js. matchOS is set statically to true in app/mobile.js.

a) We could just remove matchOS from mobile.js, and only set it in mobile-l10n.js for the multi-locale build, or
b) keep it in mobile.js and switch it to false in mobile-l10n.js for non-multi-builds.

b) is rather hacky, I think, but might be less hacky if we actually just remove mobile-l10n.js for multi-builds. It depends on mobile-l10n.js actually overwriting mobile.js, though. I think it does, needs verification, though.

The other question is how to integrate this into the build process, and I see two ways:

a) create a separate target, in either app or locales/Makefile to be called by the multi-locale factory explicitly before packaging (possibly after all locales)
b) add a hack to the make package target when AB_CD is set to multi.

Both are somewhat weird and bound rather tightly on how the factory calls into things, so I'm not too happy with either.

Comment 6

[Stuart Parmenter]

What is the status of this bug?

Comment 7

[Axel Hecht [:Pike]]

I'd need some opinion on comment 5. CCing some candidates, guess that ted, mfinkle, and aki stand in the first line.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #5)
> a) We could just remove matchOS from mobile.js, and only set it in
> mobile-l10n.js for the multi-locale build, or

> b) add a hack to the make package target when AB_CD is set to multi.

I think I prefer these two options, assuming I understand them correctly. 1a) seems more reliable than 1b), and 2b) seems cleaner than 2a) since it will apply to anyone who calls |make package| (rather than requiring someone to know about the other target).

Comment 9

[(not currently active) Ted Mielczarek]

I don't have an opinion.

Comment 10

[Axel Hecht [:Pike]]

Still waiting on the final call here, I won't get a patch for this tonight.

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

I agree with gavin in comment 8. Sounds like the better of the approaches.

Comment 12

[Axel Hecht [:Pike]]

Attachment: remove matchOS from mobile.js, and overwrite mobile-l10n.js for multi

This should do it, tested with one multi-lingo and one single-locale en-US build. Didn't have time to do extensive tests, but the multi-locale build had matchOS on with my device set to german, so regression risk should be covered at least.

Comment 13

[Axel Hecht [:Pike]]

http://hg.mozilla.org/mobile-browser/rev/00eec851d36d, FIXED.