531703 - Minimize disk space usage on Windows CE

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[Justin Dolske [:Dolske]]

We're often tight on disk space on small devices, running low can cause problems like being unable to apply app updates. A few obvious targets:

* Reduce Places history to keep down the size of places.sqlite
* Reduce disk cache to a smaller size (and possibly relocate it?)
* Clear disk cache on exit if there is a pending software update
* Clear out any .sqlite-corrupt files on start/exit
* Maybe lower limits for cookies and form history
* Look at other profile files than can grow and how we might limit them.

Comment 1

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

This should be good enough... I didn't see any other prefs that would yield significant savings, nor any other files in my (desktop) profile that would be worth nuking (with the possible exception of the XPC/XUL.mfasl files, which are a combined 4.5MB on OS X).

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 417418 [details] [diff] [review]
Patch v.1

works for me.

Comment 3

[Justin Dolske [:Dolske]]

Pushed http://hg.mozilla.org/mozilla-central/rev/1ce17c92a928

Comment 4

[Justin Dolske [:Dolske]]

Pushed to 192: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/7b527f308e84

Comment 5

[Robert Strong (they/them - no direct email)]

I wonder if the check for a pending update should be done differently in the future since this approach likely adds around 40ms to every shutdown on the tegra. The 3.6b1 nsUpdateService.js took around 44ms in js_Execute on the current tegra image and I suspect that hasn't changed much.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

we could do it in the fast start daemon when the device is idle

Comment 7

[Robert Strong (they/them - no direct email)]

Comment on attachment 417418 [details] [diff] [review]
Patch v.1

>diff --git a/browser/components/nsBrowserGlue.js b/browser/components/nsBrowserGlue.js
>--- a/browser/components/nsBrowserGlue.js
>+++ b/browser/components/nsBrowserGlue.js
>@@ -311,16 +311,28 @@
> 
>     this._observerService
>         .notifyObservers(null, "browser-ui-startup-complete", "");
>   },
> 
>   // profile shutdown handler (contains profile cleanup routines)
>   _onProfileShutdown: function() 
>   {
>+#ifdef WINCE
>+    // If there's a pending update, clear cache to free up disk space.
>+    try {
>+      let um = Cc["@mozilla.org/updates/update-manager;1"].
>+               getService(Ci.nsIUpdateManager);
>+      if (um.activeUpdate && um.activeUpdate.state == "pending") {
>+        let cacheService = Cc["@mozilla.org/network/cache-service;1"].
>+                           getService(Ci.nsICacheService);
>+        cacheService.evictEntries(Ci.nsICache.STORE_ANYWHERE);
>+      }
>+    } catch (e) { }
>+#endif
This should also be ifdef'd MOZ_UPDATER since this component isn't available if that isn't set. I am also adding AC_DEFINE for MOZ_UPDATER in Bug 526333

Comment 8

[Alfred Kayser]

Instead of ifndef's I would have used ifdef's.
That makes the reading easier...