531717 - Fix End Of Lines in /layout/*

Status: RESOLVED WONTFIX

(Core :: Layout, defect)

Description

[Serge Gautherie (:sgautherie)]

Lots of (crash)tests have CR or CR+LF EOLs instead of LF.
Maybe other files too.

Fixing this "automatically" would be good.
(Doing some more "whitespace" clean-up at the same time would be event better, if someone has time.)

Comment 1

[Bas Hickendorff]

I've a script for this (fixing both the line endings and the whitespace).

Is it the script itself that is wanted, or a patch with all the fixed whitespaces and line endings? (I can provide the latter, since my script will definitely not comply with coding standards etc...)

Testing gives:
Fixed 58558 line breaks
Removed trailing whitespace from 12181 lines
That would result in a very large patch, which is why I ask.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It's good for tests to have a diversity of line endings and whitespace styles.  We should not change tests.

It's probably better to provide the script, though I have mixed feelings about whether we should run it.

Comment 3

[Bas Hickendorff]

Sounds fair, and the script itself is definitely not suitable for inclusion.

But in fact, I guess this bug should be closed as a WONTFIX, because of the test diversity argument (which sounds indeed very reasonable to me).

This might be important because there is [good first bug] on this bug (that is how I came here). To avoid confusing other new potential contributers, closing it would be good I think.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

OK, marking wontfix, since we shouldn't change tests, and we should probably fix code only as we're otherwise changing it (to avoid making blame harder to figure out).