Closed Bug 531764 Opened 15 years ago Closed 15 years ago

XML parser in Launchpad cannot parse this xpi, due to Byte Order Mark being present where it shouldn't be

Categories

(Mozilla Localizations :: pl / Polish, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: arne, Assigned: marcoos)

Details

Attachments

(3 files)

User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091109 Ubuntu/9.10 (karmic) Firefox/3.5.5 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091109 Ubuntu/9.10 (karmic) Firefox/3.5.5 In the file locale/browser/aboutCertError.dtd exists a Byte Order Mark (U+FEFF) as first character in front of the XML tag, which causes our XML parser to exit with a error message. The Byte Order Mark is inserted by Windows based text editors automatically and should be removed manually before packaging the XPI. Patch to fix this bug is attached. Reproducible: Always
Arne: I don't think we have a global policy against using UTF-8 BOM, and UTF-8 BOM is a perfectly normal charset which should be detected by launchpad and served. In case you're interested, in python utf-8 bom is utf_8_sig and you can just read the file with this encoding to have things fly. We may want to get rid of BOM one day, but I don't think that we can call this a pl localization bug, it's rather Launchpad feature request ;)
Comment on attachment 415083 [details] [diff] [review] Patch to fix this issue We shouldn't really have BOMs here.
Attachment #415083 - Flags: review+
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #415083 - Flags: review+ → review-
...and we do not have BOMs in this file, neither on mozilla-central, nor on the 1.9.2 branch. Where did you get that file from?
it's in the pl.xpi package for Firefox 3.5.5. This is a stable release issue.
Marcoos, we have BOM in mozilla-1.9.1. I suggest to approve attached patch and ask someone for approval.
Comment on attachment 415083 [details] [diff] [review] Patch to fix this issue Oh, OK then.
Attachment #415083 - Flags: review-
Attachment #415083 - Flags: review+
Attachment #415083 - Flags: approval1.9.0.next?
Attachment #415083 - Flags: approval1.9.0.next?
Axel, can we get this into 1.9.1?
You can land it and do a sign-off, and I'll take a look. Not sure how much longer we'll do 3.5.x releases, there's a group of folks trying to figure that out.
Signed-off for any upcoming 3.5.x release, if there ever is one. Resolving as fixed.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Verified. No BOM in aboutCertError.dtd file.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: